Conversation
|
|
It's disappointing that we don't see any mypy primer changs but makes sense, given that it mainly tests the binary. |
carljm
left a comment
There was a problem hiding this comment.
Not sure I understand how it's possible that we see no primer diff here, if the mypy-primer change is working correctly, since my understanding is we previously weren't really checking any of the psycopg source code?
But this certainly doesn't seem to do any harm!
It's because we're running the same version of primer on this commit and the commit prior to this commit and then diffing the two sets of diagnostics. Since the same version of primer is being run on both commits, the same psycopg config is being used for both primer runs. |
Summary
Pulls in hauntsaninja/mypy_primer#171 which configures
psycopg's src rootThanks @sharkdp for making the change upstream
Test Plan
CI