[ty] Make unused-ignore-comment disabled by default for now#17955
Merged
AlexWaygood merged 1 commit intomainfrom May 8, 2025
Merged
[ty] Make unused-ignore-comment disabled by default for now#17955AlexWaygood merged 1 commit intomainfrom
unused-ignore-comment disabled by default for now#17955AlexWaygood merged 1 commit intomainfrom
Conversation
AlexWaygood
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
approved these changes
May 8, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks. Would you mind opening an issue so that we don't forget to re-enable the rule.
Contributor
|
AlexWaygood
force-pushed
the
alex/unused-ignore
branch
from
784a8b6 to
34367f3
Compare
Member
Author
Will do |
Contributor
|
Member
Author
|
dcreager
added a commit
that referenced
this pull request
May 8, 2025
* main: [ty] Respect the gradual guarantee when reporting errors in resolving MROs (#17962) Convert `Message::SyntaxError` to use `Diagnostic` internally (#17784) [ty] Support extending `__all__` with a literal tuple or set as well as a literal list (#17948) [ty] Make `unused-ignore-comment` disabled by default for now (#17955) [ty] Change default severity for `unbound-reference` to `error` (#17936) [ty] Ignore `possibly-unresolved-reference` by default (#17934) [ty] Default to latest supported python version (#17938) [ty] Generate and add rules table (#17953) Update the schemastore script to match changes in ty (#17952) [ty] Implement `global` handling and `load-before-global-declaration` syntax error (#17637)
dcreager
added a commit
that referenced
this pull request
May 8, 2025
* dcreager/default-typevars: clean up the diff remove trait track in type again clippy Better expansion of default typevars specialize_partial enum for TypeMapping [ty] Respect the gradual guarantee when reporting errors in resolving MROs (#17962) Specialize trait Convert `Message::SyntaxError` to use `Diagnostic` internally (#17784) [ty] Support extending `__all__` with a literal tuple or set as well as a literal list (#17948) [ty] Make `unused-ignore-comment` disabled by default for now (#17955) [ty] Change default severity for `unbound-reference` to `error` (#17936) [ty] Ignore `possibly-unresolved-reference` by default (#17934) [ty] Default to latest supported python version (#17938) [ty] Generate and add rules table (#17953) Update the schemastore script to match changes in ty (#17952) [ty] Implement `global` handling and `load-before-global-declaration` syntax error (#17637)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now it seems like there are too many situations where:
The rule feels like more of a lint anyway, and mypy's version is opt-in. I'd like for it to be enabled by default for the GA release, but right now it feels like we're getting a lot of user questions about it. Let's make it disabled-by-default until we're closer to feature-parity with other type checkers.
Test Plan
cargo testx = 1 + 2 # type: ignoreon it and verified that no diagnostics were reported by ty