[ty] Ignore possibly-unresolved-reference by default#17934
Merged
MichaReiser merged 3 commits intomainfrom May 8, 2025
Merged
Conversation
MichaReiser
added
configuration
MichaReiser
force-pushed
the
micha/disable-possibly-unbound-reference
branch
from
caf38c5 to
f423cda
Compare
MichaReiser
force-pushed
the
micha/disable-possibly-unbound-reference
branch
from
f423cda to
e2fd83c
Compare
MichaReiser
changed the title
possibly-unbound-reference by defaultpossibly-unbound-reference by default
Contributor
|
MichaReiser
force-pushed
the
micha/disable-possibly-unbound-reference
branch
2 times, most recently
from
fccbe46 to
95b924e
Compare
MichaReiser
changed the title
possibly-unbound-reference by defaultpossibly-unresolved-reference by default
MichaReiser
force-pushed
the
micha/disable-possibly-unbound-reference
branch
2 times, most recently
from
15464d6 to
3706055
Compare
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
sharkdp
reviewed
May 8, 2025
sharkdp
reviewed
May 8, 2025
Contributor
|
Thank you! I think we should only disable |
MichaReiser
force-pushed
the
micha/disable-possibly-unbound-reference
branch
from
3706055 to
4a597a8
Compare
dcreager
added a commit
that referenced
this pull request
May 8, 2025
* main: [ty] Respect the gradual guarantee when reporting errors in resolving MROs (#17962) Convert `Message::SyntaxError` to use `Diagnostic` internally (#17784) [ty] Support extending `__all__` with a literal tuple or set as well as a literal list (#17948) [ty] Make `unused-ignore-comment` disabled by default for now (#17955) [ty] Change default severity for `unbound-reference` to `error` (#17936) [ty] Ignore `possibly-unresolved-reference` by default (#17934) [ty] Default to latest supported python version (#17938) [ty] Generate and add rules table (#17953) Update the schemastore script to match changes in ty (#17952) [ty] Implement `global` handling and `load-before-global-declaration` syntax error (#17637)
dcreager
added a commit
that referenced
this pull request
May 8, 2025
* dcreager/default-typevars: clean up the diff remove trait track in type again clippy Better expansion of default typevars specialize_partial enum for TypeMapping [ty] Respect the gradual guarantee when reporting errors in resolving MROs (#17962) Specialize trait Convert `Message::SyntaxError` to use `Diagnostic` internally (#17784) [ty] Support extending `__all__` with a literal tuple or set as well as a literal list (#17948) [ty] Make `unused-ignore-comment` disabled by default for now (#17955) [ty] Change default severity for `unbound-reference` to `error` (#17936) [ty] Ignore `possibly-unresolved-reference` by default (#17934) [ty] Default to latest supported python version (#17938) [ty] Generate and add rules table (#17953) Update the schemastore script to match changes in ty (#17952) [ty] Implement `global` handling and `load-before-global-declaration` syntax error (#17637)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore the
possibly-unbound-referencerule by default because it is very noisy at the moment.We may re-enable it by default in the future.
@carljm do you want to disable all possibly- rules or only
possibly-unbound-reference?Test Plan
Updated mdtests