ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

I think the fix is always unsafe...

@VascoSch92 Thanks for the input! I’m new to the project—could you elaborate a bit? I was referencing this:

Fix availability is separate from fix safety. In some cases we might offer a diagnostic without a fix at all, regardless of safety. For this rule, that can happen if we fail to generate the new import edit, for example.

There's not really a centralized safety marker, you generally just have to search for Fix:: or safe/unsafe in the file (at least that's what I do). If all of the places where a Fix is constructed use something like Fix::unsafe_edit, then you know it's always unsafe.

Thanks for working on this!

The rule description says “exit and quit come from the site module, which is typically imported automatically during startup. However, it is not guaranteed to be imported”. If it’s not imported, the fix can change behavior.

$ cat >plr1722_1.py <<'# EOF'
exit(2)
# EOF

$ python -S plr1722_1.py; echo $?
Traceback (most recent call last):
  File "plr1722_1.py", line 1, in <module>
    exit()
    ^^^^
NameError: name 'exit' is not defined
1

$ ruff --isolated check plr1722_1.py --select PLR1722 --unsafe-fixes --fix
Found 1 error (1 fixed, 0 remaining).

$ python -S plr1722_1.py; echo $?
2

Another difference between site.exit and sys.exit is how they treat 0- and 1-element tuples. (This is undocumented and is arguably a bug in sys.exit.)

$ cat >plr1722_2.py <<'# EOF'
exit(())
# EOF

$ cat >plr1722_3.py <<'# EOF'
exit((2,))
# EOF

$ python plr1722_2.py; echo $?
()
1

$ python plr1722_3.py; echo $?
(2,)
1

$ ruff --isolated check plr1722_{2,3}.py --select PLR1722 --unsafe-fixes --fix
Found 2 errors (2 fixed, 0 remaining).

$ python plr1722_2.py; echo $?
0

$ python plr1722_3.py; echo $?
2