[pylint] add fix safety section (PLC2801)#17825
Merged
ntBre merged 3 commits intoastral-sh:mainfrom May 7, 2025
Merged
Conversation
Contributor
|
ntBre
reviewed
May 5, 2025
crates/ruff_linter/src/rules/pylint/rules/unnecessary_dunder_call.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ntBre @dscorbett thanks again for the reviews and context. I've tried my best to consolidate the cases and put together an updated explanation. Could you kindly take a look and let me know your thoughts? |
ntBre
reviewed
May 6, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I think this looks pretty good, with the exception of the first point and a small tweak to point (3).
crates/ruff_linter/src/rules/pylint/rules/unnecessary_dunder_call.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/unnecessary_dunder_call.rs
Outdated
Show resolved
Hide resolved
dcreager
added a commit
that referenced
this pull request
May 7, 2025
…lass * origin/main: [`pylint`] add fix safety section (`PLC2801`) (#17825) Add instructions on how to upgrade to a newer Rust version (#17928) [parser] Flag single unparenthesized generator expr with trailing comma in arguments. (#17893) [ty] Ensure that `T` is disjoint from `~T` even when `T` is a TypeVar (#17922) [ty] Sort collected diagnostics before snapshotting them in mdtest (#17926) [ty] Add basic file watching to server (#17912) Make completions an opt-in LSP feature (#17921) Add link to `ty` issue tracker (#17924) [ty] Add support for `__all__` (#17856) [ty] fix assigning a typevar to a union with itself (#17910) [ty] Improve UX for `[duplicate-base]` diagnostics (#17914) Clean up some Ruff references in the ty server (#17920)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parent: #15584
fix was introduced at: #9587
reasoning: #9572