[semantic-syntax-tests] Add test fixtures for AwaitOutsideAsync#17785
Merged
ntBre merged 1 commit intoastral-sh:mainfrom May 5, 2025
Merged
[semantic-syntax-tests] Add test fixtures for AwaitOutsideAsync#17785ntBre merged 1 commit intoastral-sh:mainfrom
ntBre merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
maxmynter
changed the title
ntBre
approved these changes
May 5, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks!
This doesn't actually cover AsyncComprehensionOutsideAsyncFunction, which got renamed to AsyncComprehensionInSyncComprehension in #17460 because the old name was quite confusing. It corresponds very specifically to the use of an async comprehension inside of a sync comprehension (as the new name indicates) on a specific version of Python before this was allowed. I also added tests in that PR, though, so I will go ahead and mark it covered.
AlexWaygood
pushed a commit
that referenced
this pull request
May 5, 2025
…ion` (#17785) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> Re: #17526 ## Summary Add test fixtures for `AwaitOutsideAsync` and `AsyncComprehensionOutsideAsyncFunction` errors. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan This is a test. <!-- How was it tested? -->
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 6, 2025
…ion` (astral-sh#17785) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> Re: astral-sh#17526 ## Summary Add test fixtures for `AwaitOutsideAsync` and `AsyncComprehensionOutsideAsyncFunction` errors. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan This is a test. <!-- How was it tested? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #17526
Summary
Add test fixtures for
AwaitOutsideAsyncandAsyncComprehensionOutsideAsyncFunctionerrors.Test Plan
This is a test.