[red-knot] Preliminary NamedTuple support#17738
Merged
Conversation
Contributor
|
sharkdp
force-pushed
the
david/namedtuple
branch
2 times, most recently
from
8d84d36 to
0e7ac21
Compare
Contributor
|
Member
|
❤️ love seeing all of the red in the ecosystem report! |
sharkdp
force-pushed
the
david/namedtuple
branch
from
cef3ff5 to
f1c2a49
Compare
Contributor
Author
|
The new fuzzer panics are all class C[T](C()):
pass
C.attrOn this PR, if we access |
Contributor
|
I've seen similar cases before, this is just a new way to trigger it. Consider that my responsibility to deal with, I think you can go ahead with this PR. |
dcreager
added a commit
that referenced
this pull request
May 1, 2025
* main: [red-knot] Preliminary `NamedTuple` support (#17738) [red-knot] Add tests for classes that have incompatible `__new__` and `__init__` methods (#17747) Update dependency vite to v6.2.7 (#17746) [red-knot] Update call binding to return all matching overloads (#17618) [`airflow`] apply Replacement::AutoImport to `AIR312` (#17570) [`ruff`] Add fix safety section (`RUF028`) (#17722) [syntax-errors] Detect single starred expression assignment `x = *y` (#17624) py-fuzzer: fix minimization logic when `--only-new-bugs` is passed (#17739) Fix example syntax for pydocstyle ignore_var_parameters option (#17740) [red-knot] Update salsa to prevent panic in custom panic-handler (#17742) [red-knot] Ban direct instantiation of generic protocols as well as non-generic ones (#17741) [red-knot] Lookup of `__new__` (#17733) [red-knot] Check decorator consistency on overloads (#17684) [`flake8-use-pathlib`] Avoid suggesting `Path.iterdir()` for `os.listdir` with file descriptor (`PTH208`) (#17715) [red-knot] Check overloads without an implementation (#17681) Expand Semantic Syntax Coverage (#17725) [red-knot] Check for invalid overload usages (#17609)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds preliminary support for
NamedTuples, including:NamedTupleobject__new__method, i.e. proper checking of constructor callsNamedTuple=>tuple), mainly to make type inference of named attributes possible, but also to better reflect the runtime MRO.All of this works:
Not included:
MyTuple = NamedTuple("MyTuple", […])syntaxTest Plan
New Markdown tests
Ecosystem analysis
I uploaded the ecosystem full diff (ignoring the 19k
no-matching-overloaddiagnostics) here.missing-argumentfalse positives which come from the fact that named tuples are often created using unpacking as inMyNamedTuple(*fields), which we do not understand yet.unresolved-attributefalse positives, because methods like_replaceare not available.invalid-argument-typediagnostics look like true positivesCo-authored-by: @dcreager