[red-knot] Check decorator consistency on overloads#17684
Merged
dhruvmanila merged 5 commits intomainfrom Apr 30, 2025
Merged
Conversation
dhruvmanila
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
19 tasks
dhruvmanila
force-pushed
the
dhruv/overload-without-implementation
branch
from
cb23a34 to
24158a7
Compare
dhruvmanila
force-pushed
the
dhruv/overload-decorator-consistency
branch
from
8d14303 to
0b44bd4
Compare
dhruvmanila
force-pushed
the
dhruv/overload-without-implementation
branch
from
24158a7 to
10c5adf
Compare
dhruvmanila
force-pushed
the
dhruv/overload-decorator-consistency
branch
3 times, most recently
from
18779ea to
35771de
Compare
dhruvmanila
force-pushed
the
dhruv/overload-without-implementation
branch
from
10c5adf to
9db545d
Compare
dhruvmanila
force-pushed
the
dhruv/overload-decorator-consistency
branch
from
35771de to
0403e2e
Compare
AlexWaygood
reviewed
Apr 30, 2025
Why is this required? I already updated it earlier
dhruvmanila
force-pushed
the
dhruv/overload-decorator-consistency
branch
from
6497f2d to
31f8319
Compare
dcreager
added a commit
that referenced
this pull request
May 1, 2025
* main: [red-knot] Preliminary `NamedTuple` support (#17738) [red-knot] Add tests for classes that have incompatible `__new__` and `__init__` methods (#17747) Update dependency vite to v6.2.7 (#17746) [red-knot] Update call binding to return all matching overloads (#17618) [`airflow`] apply Replacement::AutoImport to `AIR312` (#17570) [`ruff`] Add fix safety section (`RUF028`) (#17722) [syntax-errors] Detect single starred expression assignment `x = *y` (#17624) py-fuzzer: fix minimization logic when `--only-new-bugs` is passed (#17739) Fix example syntax for pydocstyle ignore_var_parameters option (#17740) [red-knot] Update salsa to prevent panic in custom panic-handler (#17742) [red-knot] Ban direct instantiation of generic protocols as well as non-generic ones (#17741) [red-knot] Lookup of `__new__` (#17733) [red-knot] Check decorator consistency on overloads (#17684) [`flake8-use-pathlib`] Avoid suggesting `Path.iterdir()` for `os.listdir` with file descriptor (`PTH208`) (#17715) [red-knot] Check overloads without an implementation (#17681) Expand Semantic Syntax Coverage (#17725) [red-knot] Check for invalid overload usages (#17609)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #15383.
As per the spec (https://typing.python.org/en/latest/spec/overload.html#invalid-overload-definitions):
For
@staticmethodand@classmethod:For
@finaland@override:Test Plan
Update existing tests; add snapshots.