[red-knot] fix narrowing in nested scopes by mtshiba · Pull Request #17630 · astral-sh/ruff

mtshiba · 2025-04-25T15:33:11Z

Summary

This PR fixes #17595.

Test Plan

New test cases are added to mdtest/narrow/conditionals/nested.md.

github-actions · 2025-04-25T15:37:11Z

`mypy_primer` results

Changes were detected when running on open source projects

async-utils (https://github.com/mikeshardmind/async-utils)
- error[lint:invalid-argument-type] src/async_utils/corofunc_cache.py:107:33: Argument to this function is incorrect: Expected `int | float`, found `int | float | None`
- error[lint:invalid-argument-type] src/async_utils/corofunc_cache.py:186:33: Argument to this function is incorrect: Expected `int | float`, found `int | float | None`
- error[lint:invalid-argument-type] src/async_utils/task_cache.py:166:33: Argument to this function is incorrect: Expected `int | float`, found `int | float | None`
- error[lint:invalid-argument-type] src/async_utils/task_cache.py:252:33: Argument to this function is incorrect: Expected `int | float`, found `int | float | None`
- Found 27 diagnostics
+ Found 23 diagnostics

beartype (https://github.com/beartype/beartype)
- error[lint:call-non-callable] beartype/_decor/_type/_pep/_decortypepep557.py:440:13: Object of type `None` is not callable
- error[lint:call-non-callable] beartype/_util/func/utilfuncframe.py:173:20: Object of type `None` is not callable
+ warning[lint:unused-ignore-comment] beartype/_util/func/utilfuncframe.py:573:63: Unused blanket `type: ignore` directive
- Found 576 diagnostics
+ Found 575 diagnostics

python-chess (https://github.com/niklasf/python-chess)
- error[lint:unsupported-operator] chess/engine.py:1683:69: Operator `>` is not supported for types `None` and `int`, in comparing `int | None` with `Literal[1]`
- error[lint:not-iterable] chess/engine.py:2349:33: Object of type `@Todo(specialized non-generic class) | None` may not be iterable
- warning[lint:possibly-unbound-attribute] chess/engine.py:2357:42: Attribute `time` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2358:100: Attribute `time` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2386:24: Attribute `time` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2386:79: Attribute `time` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2388:26: Attribute `nodes` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2388:83: Attribute `nodes` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2390:26: Attribute `depth` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2390:83: Attribute `depth` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2392:26: Attribute `mate` on type `Limit | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] chess/engine.py:2393:64: Attribute `mate` on type `Limit | None` is possibly unbound
- error[lint:unsupported-operator] chess/engine.py:2497:40: Operator `in` is not supported for types `@Todo(specialized non-generic class)` and `None`, in comparing `@Todo(specialized non-generic class)` with `str | None`
- Found 73 diagnostics
+ Found 60 diagnostics

pyinstrument (https://github.com/joerick/pyinstrument)
- error[lint:no-matching-overload] pyinstrument/processors.py:123:52: No overload of function `match` matches arguments
- error[lint:no-matching-overload] pyinstrument/processors.py:124:52: No overload of function `match` matches arguments
- Found 106 diagnostics
+ Found 104 diagnostics

anyio (https://github.com/agronholm/anyio)
- warning[lint:possibly-unbound-attribute] src/anyio/_backends/_asyncio.py:820:55: Attribute `cancelled` on type `Future | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/anyio/_backends/_asyncio.py:823:50: Attribute `done` on type `Future | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/anyio/_backends/_asyncio.py:830:21: Attribute `set_exception` on type `Future | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/anyio/_backends/_asyncio.py:831:57: Attribute `done` on type `Future | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/anyio/_backends/_asyncio.py:832:17: Attribute `set_exception` on type `Future | None` is possibly unbound
- Found 148 diagnostics
+ Found 143 diagnostics

strawberry (https://github.com/strawberry-graphql/strawberry)
- error[lint:call-non-callable] strawberry/extensions/context.py:122:39: Object of type `None` is not callable
- error[lint:call-non-callable] strawberry/extensions/context.py:127:39: Object of type `None` is not callable
- error[lint:call-non-callable] strawberry/extensions/context.py:134:17: Object of type `None` is not callable
- error[lint:call-non-callable] strawberry/extensions/context.py:139:17: Object of type `None` is not callable
- error[lint:unsupported-operator] strawberry/relay/types.py:869:35: Unary operator `-` is unsupported for type `int | None`
- Found 555 diagnostics
+ Found 550 diagnostics

starlette (https://github.com/encode/starlette)
- error[lint:invalid-raise] starlette/middleware/base.py:156:27: Cannot raise object of type `Exception | None` (must be a `BaseException` subclass or instance)
- Found 215 diagnostics
+ Found 214 diagnostics

graphql-core (https://github.com/graphql-python/graphql-core)
- error[lint:unsupported-operator] src/graphql/execution/values.py:62:39: Operator `>=` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- Found 560 diagnostics
+ Found 559 diagnostics

python-sop (https://gitlab.com/dkg/python-sop)
- warning[lint:possibly-unbound-attribute] sop/__init__.py:331:13: Attribute `autocomplete` on type `Unknown | None` is possibly unbound
- Found 12 diagnostics
+ Found 11 diagnostics

trio (https://github.com/python-trio/trio)
- error[lint:call-non-callable] src/trio/_core/_thread_cache.py:158:13: Object of type `None` is not callable
- error[lint:call-non-callable] src/trio/_core/_thread_cache.py:172:17: Object of type `None` is not callable
- error[lint:call-non-callable] src/trio/_core/_thread_cache.py:179:17: Object of type `None` is not callable
- error[lint:invalid-argument-type] src/trio/_deprecate.py:115:79: Argument to this function is incorrect: Expected `int`, found `int | None`
- error[lint:invalid-argument-type] src/trio/_tests/test_dtls.py:73:53: Argument to this function is incorrect: Expected `int`, found `int | None`
- Found 1135 diagnostics
+ Found 1130 diagnostics

kopf (https://github.com/nolar/kopf)
- error[lint:unsupported-operator] kopf/_cogs/clients/scanning.py:70:64: Operator `in` is not supported for types `@Todo(generic `typing.Awaitable` type)` and `None`, in comparing `@Todo(generic `typing.Awaitable` type)` with `@Todo(specialized non-generic class) | None`
- warning[lint:possibly-unbound-attribute] kopf/_core/reactor/queueing.py:157:17: Attribute `cancel` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:53:9: Attribute `_activities` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:80:9: Attribute `_activities` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:108:9: Attribute `_activities` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:136:9: Attribute `_activities` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:196:9: Attribute `_webhooks` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:256:9: Attribute `_webhooks` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:313:9: Attribute `_changing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:369:9: Attribute `_changing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:427:9: Attribute `_changing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:484:9: Attribute `_changing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:542:9: Attribute `_changing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:596:9: Attribute `_indexing` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:646:9: Attribute `_watching` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:708:9: Attribute `_spawning` on type `OperatorRegistry | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] kopf/on.py:768:9: Attribute `_spawning` on type `OperatorRegistry | None` is possibly unbound
- Found 294 diagnostics
+ Found 277 diagnostics

kornia (https://github.com/kornia/kornia)
- warning[lint:call-possibly-unbound-method] kornia/contrib/models/tiny_vit.py:307:21: Method `__getitem__` of type `int | float | @Todo(specialized non-generic class)` is possibly unbound
- error[lint:unsupported-operator] kornia/core/mixin/image_module.py:67:28: Operator `in` is not supported for types `@Todo(Support for `typing.Self`)` and `None`, in comparing `@Todo(Support for `typing.Self`)` with `list | None`
- error[lint:unsupported-operator] kornia/core/mixin/image_module.py:71:28: Operator `in` is not supported for types `@Todo(specialized non-generic class)` and `None`, in comparing `@Todo(specialized non-generic class)` with `list | None`
- warning[lint:call-possibly-unbound-method] kornia/core/mixin/onnx.py:155:81: Method `__getitem__` of type `@Todo(specialized non-generic class) | None` is possibly unbound
- error[lint:unsupported-operator] kornia/core/module.py:73:28: Operator `in` is not supported for types `@Todo(Support for `typing.Self`)` and `None`, in comparing `@Todo(Support for `typing.Self`)` with `@Todo(specialized non-generic class) | None`
- error[lint:unsupported-operator] kornia/core/module.py:77:28: Operator `in` is not supported for types `@Todo(specialized non-generic class)` and `None`, in comparing `@Todo(specialized non-generic class)` with `@Todo(specialized non-generic class) | None`
- error[lint:call-non-callable] kornia/feature/lightglue.py:139:27: Object of type `None` is not callable
- warning[lint:call-possibly-unbound-method] kornia/models/detection/utils.py:118:81: Method `__getitem__` of type `list | None` is possibly unbound
- error[lint:call-non-callable] kornia/x/trainer.py:95:28: Object of type `None` is not callable
- Found 1013 diagnostics
+ Found 1004 diagnostics

check-jsonschema (https://github.com/python-jsonschema/check-jsonschema)
- error[lint:invalid-argument-type] src/check_jsonschema/schema_loader/resolver.py:62:45: Argument to this function is incorrect: Argument type `Unknown | str | None` does not satisfy constraints of type variable `AnyStr`
- error[lint:invalid-argument-type] src/check_jsonschema/schema_loader/resolver.py:62:45: Argument to this function is incorrect: Expected `str`, found `Unknown | str | None`
- Found 66 diagnostics
+ Found 64 diagnostics

sockeye (https://github.com/awslabs/sockeye)
- warning[lint:possibly-unbound-attribute] sockeye/checkpoint_decoder.py:160:66: Attribute `format` on type `str | None` is possibly unbound
- error[lint:unsupported-operator] sockeye/inference.py:107:20: Operator `+` is unsupported between objects of type `int | None` and `Unknown | Literal[1]`
- Found 394 diagnostics
+ Found 392 diagnostics

porcupine (https://github.com/Akuli/porcupine)
- error[lint:invalid-return-type] porcupine/_state.py:91:12: Return type does not match returned value: Expected `_State`, found `_State | None`
- warning[lint:possibly-unbound-attribute] porcupine/plugins/filemanager.py:363:40: Attribute `path` on type `PasteState | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:479:48: Attribute `textwidget` on type `NoTerminalRunner | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:480:37: Attribute `textwidget` on type `NoTerminalRunner | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:486:50: Attribute `textwidget` on type `NoTerminalRunner | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:488:50: Attribute `textwidget` on type `NoTerminalRunner | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:494:46: Attribute `textwidget` on type `NoTerminalRunner | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] porcupine/plugins/run/no_terminal.py:495:5: Attribute `run_command` on type `NoTerminalRunner | None` is possibly unbound
- error[lint:invalid-argument-type] porcupine/plugins/statusbar.py:126:40: Argument to this function is incorrect: Expected `str`, found `str | None`
- error[lint:invalid-return-type] porcupine/settings.py:580:12: Return type does not match returned value: Expected `Frame`, found `Frame | None`
- error[lint:invalid-argument-type] porcupine/utils.py:796:38: Argument to this function is incorrect: Expected `str | _T`, found `str | None`
- Found 123 diagnostics
+ Found 112 diagnostics

pydantic (https://github.com/pydantic/pydantic)
- error[lint:call-non-callable] pydantic/_internal/_generate_schema.py:2219:26: Object of type `None` is not callable
- error[lint:invalid-argument-type] pydantic/v1/dataclasses.py:231:62: Argument to this function is incorrect: Expected `bool`, found `bool | None`
- Found 908 diagnostics
+ Found 906 diagnostics

pip (https://github.com/pypa/pip)
- error[lint:unsupported-operator] src/pip/_internal/locations/__init__.py:158:46: Operator `not in` is not supported for types `str` and `None`, in comparing `Literal["/lib64/"]` with `str | None`
- error[lint:call-non-callable] src/pip/_internal/locations/_sysconfig.py:71:16: Object of type `None` is not callable
- error[lint:call-non-callable] src/pip/_internal/locations/_sysconfig.py:90:16: Object of type `None` is not callable
- error[lint:call-non-callable] src/pip/_internal/locations/_sysconfig.py:105:16: Object of type `None` is not callable
- error[lint:invalid-argument-type] src/pip/_internal/metadata/base.py:347:66: Argument to this function is incorrect: Expected `str`, found `str | None`
- warning[lint:possibly-unbound-attribute] src/pip/_internal/req/req_file.py:434:39: Attribute `format_control` on type `PackageFinder | None` is possibly unbound
- error[lint:invalid-return-type] src/pip/_internal/utils/logging.py:155:16: Return type does not match returned value: Expected `Console`, found `Unknown | None`
- error[lint:invalid-return-type] src/pip/_internal/utils/logging.py:158:16: Return type does not match returned value: Expected `Console`, found `Unknown | None`
- warning[lint:possibly-unbound-attribute] src/pip/_internal/utils/temp_dir.py:145:13: Attribute `enter_context` on type `ExitStack[bool | None] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_internal/utils/temp_dir.py:162:22: Attribute `get_delete` on type `TempDirectoryTypeRegistry | None` is possibly unbound
- error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/__main__.py:55:33: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `Unknown | dict[Unknown, Unknown]`
+ error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/__main__.py:55:33: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `@Todo(map_with_boundness: intersections with negative contributions) | dict[Unknown, Unknown]`
- error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/_lint_dependency_groups.py:38:44: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `Unknown | dict[Unknown, Unknown]`
+ error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/_lint_dependency_groups.py:38:44: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `@Todo(map_with_boundness: intersections with negative contributions) | dict[Unknown, Unknown]`
- error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/_pip_wrapper.py:42:44: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `Unknown | dict[Unknown, Unknown]`
+ error[lint:invalid-argument-type] src/pip/_vendor/dependency_groups/_pip_wrapper.py:42:44: Argument to this function is incorrect: Expected `Mapping[str, str | Mapping[str, str]]`, found `@Todo(map_with_boundness: intersections with negative contributions) | dict[Unknown, Unknown]`
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/distlib/wheel.py:116:31: Attribute `get_suffixes` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/distlib/wheel.py:124:16: Attribute `load_dynamic` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/requests/help.py:80:47: Attribute `__version__` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/requests/help.py:82:36: Attribute `__version__` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/requests/help.py:90:24: Attribute `__version__` on type `None | Unknown` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/requests/help.py:91:35: Attribute `SSL` on type `None | Unknown` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/rich/pretty.py:205:13: Attribute `print` on type `Console | None` is possibly unbound
- error[lint:unsupported-operator] src/pip/_vendor/rich/pretty.py:606:17: Operator `>` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] src/pip/_vendor/rich/pretty.py:608:25: Operator `-` is unsupported between objects of type `int` and `int | None`
- error[lint:unsupported-operator] src/pip/_vendor/rich/pretty.py:631:55: Operator `>=` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] src/pip/_vendor/rich/pretty.py:862:47: Operator `>` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] src/pip/_vendor/rich/pretty.py:863:52: Operator `-` is unsupported between objects of type `int` and `int | None`
- error[lint:unsupported-operator] src/pip/_vendor/rich/syntax.py:503:35: Operator `-` is unsupported between objects of type `Unknown | int | None` and `Literal[1]`
- error[lint:unsupported-operator] src/pip/_vendor/rich/syntax.py:519:45: Operator `>=` is not supported for types `int` and `None`, in comparing `Literal[1, 2]` with `Unknown | int | None`
- warning[lint:possibly-unbound-attribute] src/pip/_vendor/urllib3/util/ssl_.py:498:9: Attribute `_validate_ssl_context_for_tls_in_tls` on type `None | Literal[SSLTransport]` is possibly unbound
- error[lint:call-non-callable] src/pip/_vendor/urllib3/util/ssl_.py:499:16: Object of type `None` is not callable
- Found 1089 diagnostics
+ Found 1063 diagnostics

websockets (https://github.com/aaugustin/websockets)
- error[lint:call-non-callable] src/websockets/asyncio/server.py:782:28: Object of type `None` is not callable
- warning[lint:call-possibly-unbound-method] src/websockets/imports.py:74:22: Method `__getitem__` of type `dict[str, str] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] src/websockets/imports.py:82:22: Method `__getitem__` of type `dict[str, str] | None` is possibly unbound
- error[lint:call-non-callable] src/websockets/sync/server.py:562:28: Object of type `None` is not callable
- error[lint:call-non-callable] src/websockets/sync/server.py:578:26: Object of type `None` is not callable
- Found 130 diagnostics
+ Found 125 diagnostics

jinja (https://github.com/pallets/jinja)
- error[lint:call-non-callable] src/jinja2/filters.py:79:20: Object of type `None` is not callable
- error[lint:call-non-callable] src/jinja2/filters.py:118:26: Object of type `None` is not callable
- Found 387 diagnostics
+ Found 385 diagnostics

SinbadCogs (https://github.com/mikeshardmind/SinbadCogs)
- warning[lint:possibly-unbound-attribute] relays/helpers.py:106:28: Attribute `group` on type `Unknown | (Unknown & ~AlwaysFalsy) | Match[str] | None` is possibly unbound
- Found 179 diagnostics
+ Found 178 diagnostics

mkosi (https://github.com/systemd/mkosi)
- error[lint:no-matching-overload] mkosi/config.py:1140:25: No overload of bound method `replace` matches arguments
- error[lint:no-matching-overload] mkosi/config.py:1228:25: No overload of bound method `replace` matches arguments
- Found 336 diagnostics
+ Found 334 diagnostics

aiohttp-devtools (https://github.com/aio-libs/aiohttp-devtools)
+ warning[lint:unused-ignore-comment] aiohttp_devtools/runserver/serve.py:50:51: Unused blanket `type: ignore` directive
+ warning[lint:unused-ignore-comment] aiohttp_devtools/runserver/serve.py:60:43: Unused blanket `type: ignore` directive
- Found 60 diagnostics
+ Found 62 diagnostics

black (https://github.com/psf/black)
- warning[lint:possibly-unbound-attribute] src/black/trans.py:2479:9: Attribute `insert_child` on type `Unknown | Node | None` is possibly unbound
- Found 141 diagnostics
+ Found 140 diagnostics

werkzeug (https://github.com/pallets/werkzeug)
- warning[lint:possibly-unbound-attribute] src/werkzeug/serving.py:267:37: Attribute `split` on type `str | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/werkzeug/serving.py:267:37: Attribute `split` on type `str | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/werkzeug/serving.py:267:37: Attribute `split` on type `str | None` is possibly unbound
- error[lint:not-iterable] src/werkzeug/serving.py:273:35: Object of type `@Todo(specialized non-generic class) | None` may not be iterable
- error[lint:call-non-callable] tests/test_datastructures.py:953:20: Object of type `None` is not callable
- Found 612 diagnostics
+ Found 607 diagnostics

asynq (https://github.com/quora/asynq)
- error[lint:call-non-callable] asynq/debug.py:279:9: Object of type `None` is not callable
- Found 271 diagnostics
+ Found 270 diagnostics

poetry (https://github.com/python-poetry/poetry)
- error[lint:unsupported-operator] src/poetry/layouts/layout.py:196:36: Operator `+` is unsupported between objects of type `Literal[">="]` and `str | None`
- error[lint:unsupported-operator] src/poetry/layouts/layout.py:200:37: Operator `+` is unsupported between objects of type `Literal["<"]` and `str | None`
- error[lint:call-non-callable] tests/conftest.py:726:28: Object of type `str` is not callable
- warning[lint:call-possibly-unbound-method] tests/inspection/test_lazy_wheel.py:149:20: Method `__getitem__` of type `tuple[int, bytes] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/inspection/test_lazy_wheel.py:151:20: Method `__getitem__` of type `tuple[int, bytes] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/inspection/test_lazy_wheel.py:153:22: Method `__getitem__` of type `tuple[int, bytes] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/inspection/test_lazy_wheel.py:157:25: Method `__getitem__` of type `tuple[int, bytes] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/inspection/test_lazy_wheel.py:159:25: Method `__getitem__` of type `tuple[int, bytes] | None` is possibly unbound
- error[lint:call-non-callable] tests/repositories/fixtures/legacy.py:136:22: Object of type `str` is not callable
- Found 1149 diagnostics
+ Found 1140 diagnostics

urllib3 (https://github.com/urllib3/urllib3)
- warning[lint:possibly-unbound-attribute] dummyserver/testcase.py:112:31: Attribute `wait` on type `Event | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] dummyserver/testcase.py:116:21: Attribute `clear` on type `Event | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/urllib3/contrib/emscripten/fetch.py:462:16: Attribute `send` on type `_StreamingFetcher | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/urllib3/contrib/emscripten/fetch.py:698:16: Attribute `streaming_ready` on type `_StreamingFetcher | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/urllib3/contrib/emscripten/fetch.py:705:15: Attribute `js_worker_ready_promise` on type `_StreamingFetcher | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/urllib3/response.py:311:35: Attribute `error` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] src/urllib3/util/ssl_.py:298:15: Object of type `None` is not callable
- error[lint:invalid-assignment] src/urllib3/util/ssl_.py:301:9: Object of type `int | (Unknown & ~None)` is not assignable to attribute `minimum_version` on type `Unknown | SSLContext`
+ error[lint:invalid-assignment] src/urllib3/util/ssl_.py:301:9: Object of type `int | (Unknown & ~None)` is not assignable to attribute `minimum_version` of type `TLSVersion`
- error[lint:invalid-assignment] src/urllib3/util/ssl_.py:306:9: Object of type `int | (Unknown & ~None)` is not assignable to attribute `maximum_version` on type `Unknown | SSLContext`
+ error[lint:invalid-assignment] src/urllib3/util/ssl_.py:306:9: Object of type `int | (Unknown & ~None)` is not assignable to attribute `maximum_version` of type `TLSVersion`
- error[lint:invalid-assignment] src/urllib3/util/ssl_.py:356:9: Object of type `int` is not assignable to attribute `verify_mode` on type `Unknown | SSLContext`
+ error[lint:invalid-assignment] src/urllib3/util/ssl_.py:356:9: Object of type `int` is not assignable to attribute `verify_mode` of type `VerifyMode`
- error[lint:invalid-assignment] src/urllib3/util/ssl_.py:360:9: Object of type `int` is not assignable to attribute `verify_mode` on type `Unknown | SSLContext`
+ error[lint:invalid-assignment] src/urllib3/util/ssl_.py:360:9: Object of type `int` is not assignable to attribute `verify_mode` of type `VerifyMode`
- warning[lint:possibly-unbound-attribute] src/urllib3/util/ssl_.py:521:9: Attribute `_validate_ssl_context_for_tls_in_tls` on type `None | Literal[SSLTransport]` is possibly unbound
- error[lint:call-non-callable] src/urllib3/util/ssl_.py:522:16: Object of type `None` is not callable
- Found 537 diagnostics
+ Found 528 diagnostics

ignite (https://github.com/pytorch/ignite)
- warning[lint:possibly-unbound-attribute] examples/references/classification/imagenet/vis.py:92:61: Attribute `state` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] examples/references/segmentation/pascal_voc2012/vis.py:123:61: Attribute `state` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ignite/engine/__init__.py:210:13: Attribute `scale` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ignite/engine/__init__.py:212:17: Attribute `step` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ignite/engine/__init__.py:213:17: Attribute `update` on type `Unknown | None` is possibly unbound
- error[lint:invalid-assignment] ignite/handlers/utils.py:21:13: Object of type `Events | None` is not assignable to `Events`
- warning[lint:call-possibly-unbound-method] ignite/metrics/classification_report.py:145:16: Method `__getitem__` of type `list | None` is possibly unbound
- Found 2566 diagnostics
+ Found 2559 diagnostics

tornado (https://github.com/tornadoweb/tornado)
- error[lint:unsupported-operator] tornado/auth.py:236:22: Operator `+` is unsupported between objects of type `Literal["openid."]` and `Unknown | None`
- error[lint:unsupported-operator] tornado/auth.py:241:31: Operator `+` is unsupported between objects of type `Literal["openid."]` and `Unknown | None`
- warning[lint:call-possibly-unbound-method] tornado/autoreload.py:231:36: Method `__getitem__` of type `list | None | @Todo(specialized non-generic class)` is possibly unbound
- error[lint:call-non-callable] tornado/httpclient.py:107:20: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] tornado/log.py:64:21: Attribute `initialise` on type `Unknown | None` is possibly unbound
- Found 557 diagnostics
+ Found 552 diagnostics

Expression (https://github.com/cognitedata/Expression)
- error[lint:call-non-callable] expression/core/mailbox.py:87:17: Object of type `None` is not callable
- Found 555 diagnostics
+ Found 554 diagnostics

pwndbg (https://github.com/pwndbg/pwndbg)
- error[lint:invalid-argument-type] pwndbg/aglib/godbg.py:576:43: Argument to this function is incorrect: Expected `str`, found `Unknown | str | None`
- error[lint:unsupported-operator] pwndbg/aglib/godbg.py:627:49: Operator `+` is unsupported between objects of type `Unknown | int | None` and `int`
- error[lint:unsupported-operator] pwndbg/aglib/godbg.py:628:36: Operator `+` is unsupported between objects of type `Unknown | int | None` and `int`
- error[lint:unsupported-operator] pwndbg/commands/context.py:711:43: Operator `+` is unsupported between objects of type `int | None` and `Literal[1]`
- warning[lint:possibly-unbound-attribute] pwndbg/integration/ida.py:147:33: Attribute `init_hexrays_plugin` on type `ServerProxy | None` is possibly unbound
- Found 2827 diagnostics
+ Found 2822 diagnostics

mitmproxy (https://github.com/mitmproxy/mitmproxy)
- error[lint:invalid-argument-type] mitmproxy/net/tls.py:161:37: Argument to this function is incorrect: Expected `(Connection, bytes, /) -> object`, found `Unknown | MasterSecretLogger | None`
- error[lint:call-non-callable] mitmproxy/tools/main.py:104:31: Object of type `None` is not callable
- Found 2197 diagnostics
+ Found 2195 diagnostics

vision (https://github.com/pytorch/vision)
- error[lint:no-matching-overload] setup.py:133:30: No overload of function `split` matches arguments
- warning[lint:possibly-unbound-attribute] torchvision/models/_api.py:228:101: Attribute `__name__` on type `ModuleType | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] torchvision/transforms/_functional_pil.py:18:46: Attribute `Image` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] torchvision/transforms/functional.py:161:49: Attribute `Image` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] torchvision/transforms/functional.py:202:49: Attribute `Image` on type `Unknown | None` is possibly unbound
- Found 2469 diagnostics
+ Found 2464 diagnostics

pyppeteer (https://github.com/pyppeteer/pyppeteer)
- error[lint:call-non-callable] pyppeteer/page.py:939:29: Object of type `str` is not callable
- error[lint:call-non-callable] pyppeteer/page.py:973:29: Object of type `str` is not callable
- Found 174 diagnostics
+ Found 172 diagnostics

boostedblob (https://github.com/hauntsaninja/boostedblob)
- error[lint:unsupported-operator] boostedblob/copying.py:383:25: Operator `/` is unsupported between objects of type `BasePath | BlobPath | str` and `str`
- error[lint:unsupported-operator] boostedblob/copying.py:456:36: Operator `/` is unsupported between objects of type `BasePath | BlobPath | str` and `str`
- warning[lint:possibly-unbound-attribute] boostedblob/syncing.py:57:72: Attribute `search` on type `Unknown | Pattern[str] | None` is possibly unbound
- Found 140 diagnostics
+ Found 137 diagnostics

mypy (https://github.com/python/mypy)
- error[lint:unresolved-attribute] mypy/checker.py:5942:35: Type `Expression` has no attribute `name`
- error[lint:unresolved-attribute] mypy/checker.py:5943:48: Type `Expression` has no attribute `fullname`
- error[lint:unresolved-attribute] mypy/checker.py:5944:28: Type `Expression` has no attribute `fullname`
- error[lint:unresolved-attribute] mypy/checker.py:5946:31: Type `Expression` has no attribute `callee`
- error[lint:unresolved-attribute] mypy/checker.py:5947:32: Type `Expression` has no attribute `callee`
- error[lint:unresolved-attribute] mypy/checker.py:5948:33: Type `Expression` has no attribute `callee`
- error[lint:unresolved-attribute] mypy/checker.py:5948:59: Type `Expression` has no attribute `callee`
- error[lint:unresolved-attribute] mypy/checker.py:5949:32: Type `Expression` has no attribute `callee`
- error[lint:unresolved-attribute] mypy/checker.py:5956:28: Type `Expression` has no attribute `name`
- error[lint:unsupported-operator] mypy/erasetype.py:151:16: Operator `in` is not supported for types `TypeVarId` and `None`, in comparing `TypeVarId` with `@Todo(specialized non-generic class) | None`
- error[lint:invalid-argument-type] mypy/stubgenc.py:338:50: Argument to this function is incorrect: Expected `Sized`, found `Unknown | None`
- warning[lint:call-possibly-unbound-method] mypy/stubgenc.py:339:24: Method `__getitem__` of type `Unknown | None` is possibly unbound
- error[lint:invalid-argument-type] mypy/stubgenc.py:339:54: Argument to this function is incorrect: Expected `Sized`, found `Unknown | None`
- error[lint:unsupported-operator] mypy/stubgenc.py:353:35: Operator `in` is not supported for types `str` and `None`, in comparing `str` with `Unknown | dict[str, Any] | None`
- warning[lint:call-possibly-unbound-method] mypy/stubgenc.py:354:24: Method `__getitem__` of type `Unknown | dict[str, Any] | None` is possibly unbound
- error[lint:invalid-argument-type] mypyc/irbuild/statement.py:788:53: Argument to this function is incorrect: Expected `Value | AssignmentTarget`, found `Unknown | None | Value | AssignmentTarget`
- Found 3275 diagnostics
+ Found 3259 diagnostics

operator (https://github.com/canonical/operator)
- error[lint:unsupported-operator] ops/_private/harness.py:3887:77: Operator `in` is not supported for types `Unknown` and `None`, in comparing `Unknown` with `(@Todo(specialized non-generic class) & None) | None | frozenset`
- Found 248 diagnostics
+ Found 247 diagnostics

AutoSplit (https://github.com/Toufool/AutoSplit)
- warning[lint:possibly-unbound-attribute] src/AutoSplit.py:996:17: Attribute `accept` on type `QCloseEvent | None` is possibly unbound
- Found 77 diagnostics
+ Found 76 diagnostics

pytest (https://github.com/pytest-dev/pytest)
- error[lint:call-non-callable] src/_pytest/unittest.py:145:21: Object of type `None` is not callable
- error[lint:call-non-callable] src/_pytest/unittest.py:155:21: Object of type `None` is not callable
- error[lint:call-non-callable] src/_pytest/unittest.py:185:17: Object of type `None` is not callable
- error[lint:call-non-callable] src/_pytest/unittest.py:188:17: Object of type `None` is not callable
- error[lint:invalid-return-type] testing/test_assertion.py:36:28: Return type does not match returned value: Expected `int`, found `int | None`
- Found 918 diagnostics
+ Found 913 diagnostics

arviz (https://github.com/arviz-devs/arviz)
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:99:33: Attribute `_TEXT_OR_BYTES` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:100:34: Attribute `collections_abc` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:101:12: Attribute `_is_namedtuple` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:102:12: Attribute `_is_attrs` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:106:27: Attribute `_yield_sorted_items` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:107:45: Attribute `_yield_sorted_items` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:107:45: Attribute `_yield_sorted_items` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] arviz/data/base.py:107:45: Attribute `_yield_sorted_items` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] arviz/plots/ecdfplot.py:274:15: Object of type `None` is not callable
- Found 2664 diagnostics
+ Found 2655 diagnostics

optuna (https://github.com/optuna/optuna)
- error[lint:invalid-argument-type] optuna/_deprecated.py:95:34: Argument to this function is incorrect: Expected `str`, found `str | None`
- error[lint:unsupported-operator] optuna/_deprecated.py:112:28: Operator `+` is unsupported between objects of type `Literal[" "]` and `str | None`
- error[lint:unsupported-operator] optuna/_deprecated.py:173:32: Operator `+` is unsupported between objects of type `Literal[" "]` and `str | None`
- error[lint:invalid-argument-type] optuna/_deprecated.py:191:38: Argument to this function is incorrect: Expected `str`, found `str | None`
- error[lint:call-non-callable] optuna/importance/_base.py:154:13: Object of type `None` is not callable
- error[lint:call-non-callable] optuna/importance/_base.py:175:22: Object of type `None` is not callable
- error[lint:invalid-argument-type] optuna/logging.py:247:46: Argument to this function is incorrect: Expected `Handler`, found `Handler | None`
- error[lint:invalid-argument-type] optuna/logging.py:259:43: Argument to this function is incorrect: Expected `Handler`, found `Handler | None`
- error[lint:call-non-callable] optuna/samplers/_tpe/sampler.py:757:64: Object of type `None` is not callable
- error[lint:invalid-argument-type] tests/study_tests/test_optimize.py:88:38: Argument to this function is incorrect: Expected `int | float`, found `int | float | None`
- Found 2287 diagnostics
+ Found 2277 diagnostics

rich (https://github.com/Textualize/rich)
- warning[lint:possibly-unbound-attribute] rich/pretty.py:205:13: Attribute `print` on type `Console | None` is possibly unbound
- error[lint:unsupported-operator] rich/pretty.py:606:17: Operator `>` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] rich/pretty.py:608:25: Operator `-` is unsupported between objects of type `int` and `int | None`
- error[lint:unsupported-operator] rich/pretty.py:631:55: Operator `>=` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] rich/pretty.py:862:47: Operator `>` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] rich/pretty.py:863:52: Operator `-` is unsupported between objects of type `int` and `int | None`
- error[lint:unsupported-operator] rich/syntax.py:503:35: Operator `-` is unsupported between objects of type `Unknown | int | None` and `Literal[1]`
- error[lint:unsupported-operator] rich/syntax.py:519:45: Operator `>=` is not supported for types `int` and `None`, in comparing `Literal[1, 2]` with `Unknown | int | None`
- Found 502 diagnostics
+ Found 494 diagnostics

mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
- warning[lint:possibly-unbound-attribute] pymongo/pyopenssl_context.py:310:24: Attribute `encode` on type `str | None` is possibly unbound
- Found 844 diagnostics
+ Found 843 diagnostics

meson (https://github.com/mesonbuild/meson)
- error[lint:unresolved-attribute] mesonbuild/cargo/interpreter.py:82:19: Type `ModuleType | None` has no attribute `load`
- warning[lint:possibly-unbound-attribute] mesonbuild/cmake/generator.py:53:29: Attribute `properties` on type `CMakeTarget | None` is possibly unbound
- error[lint:invalid-argument-type] mesonbuild/interpreterbase/decorators.py:198:49: Argument to this function is incorrect: Expected `Sized`, found `list | None`
- error[lint:invalid-argument-type] mesonbuild/interpreterbase/decorators.py:199:84: Argument to this function is incorrect: Expected `Sized`, found `list | None`
- warning[lint:call-possibly-unbound-method] mesonbuild/interpreterbase/decorators.py:203:56: Method `__getitem__` of type `list | None` is possibly unbound
- error[lint:invalid-argument-type] mesonbuild/interpreterbase/decorators.py:230:47: Argument to this function is incorrect: Expected `Sized`, found `list | None`
- error[lint:invalid-argument-type] mesonbuild/interpreterbase/decorators.py:231:44: Argument to this function is incorrect: Expected `Sized`, found `list | None`
- error[lint:unsupported-operator] mesonbuild/interpreterbase/decorators.py:493:28: Operator `in` is not supported for types `@Todo(specialized non-generic class)` and `None`, in comparing `@Todo(specialized non-generic class) & ~ContainerTypeInfo & ~type` with `Unknown | None | list`
- warning[lint:possibly-unbound-attribute] mesonbuild/interpreterbase/decorators.py:496:33: Attribute `keys` on type `Unknown | None | list` is possibly unbound
- error[lint:too-many-positional-arguments] mesonbuild/modules/sourceset.py:235:50: Too many positional arguments to bound method `get`: expected 1, got 2
- warning[lint:call-possibly-unbound-method] mesonbuild/modules/sourceset.py:243:50: Method `__getitem__` of type `Unknown | tuple[str | int, str | None] | None` is possibly unbound
- error[lint:invalid-argument-type] run_meson_command_tests.py:37:48: Argument to this function is incorrect: Expected `str`, found `Unknown | None | (Unknown & ~Literal["posix_local"]) | Literal["posix_prefix"]`
- error[lint:invalid-argument-type] run_meson_command_tests.py:46:46: Argument to this function is incorrect: Expected `str`, found `Unknown | None | (Unknown & ~Literal["posix_local"]) | Literal["posix_prefix"]`
- error[lint:unsupported-operator] run_project_tests.py:800:29: Operator `in` is not supported for types `Unknown` and `_VT`, in comparing `Unknown` with `Unknown | (_VT & ~Literal["thirdparty"]) | (Unknown & ~Literal["thirdparty"]) | None`
+ error[lint:unsupported-operator] run_project_tests.py:800:29: Operator `in` is not supported for types `Unknown` and `_VT`, in comparing `Unknown` with `(Unknown & ~None) | (_VT & ~Literal["thirdparty"] & ~None) | (Unknown & ~Literal["thirdparty"] & ~None)`
- warning[lint:possibly-unbound-attribute] run_project_tests.py:1607:13: Attribute `unlink` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] run_project_tests.py:1612:13: Attribute `unlink` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] run_project_tests.py:1617:13: Attribute `unlink` on type `Unknown | None` is possibly unbound
- error[lint:unsupported-operator] run_tests.py:324:47: Operator `+` is unsupported between objects of type `Unknown | list | None` and `list`
- Found 1695 diagnostics
+ Found 1678 diagnostics

static-frame (https://github.com/static-frame/static-frame)
- warning[lint:call-possibly-unbound-method] static_frame/core/container_util.py:205:27: Method `__getitem__` of type `@Todo(specialized non-generic class) | IndexBase | ndarray[Any, Any] | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] static_frame/core/container_util.py:266:27: Method `__getitem__` of type `@Todo(specialized non-generic class) | None | IndexBase` is possibly unbound
- warning[lint:call-possibly-unbound-method] static_frame/core/container_util.py:309:27: Method `__getitem__` of type `@Todo(specialized non-generic class) | IndexBase | None` is possibly unbound
- error[lint:call-non-callable] static_frame/core/frame.py:1046:42: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1048:42: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1052:42: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1212:66: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1342:66: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1442:27: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1444:26: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:1446:26: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] static_frame/core/frame.py:1549:35: Attribute `to_type_filter_array` on type `StoreFilter | None` is possibly unbound
- error[lint:call-non-callable] static_frame/core/frame.py:1553:29: Object of type `None` is not callable
- error[lint:call-non-callable] static_frame/core/frame.py:3079:29: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] static_frame/core/quilt.py:586:44: Attribute `cell_placeholder` on type `DisplayConfig | None` is possibly unbound
- error[lint:invalid-argument-type] static_frame/test/property/strategies.py:750:21: Argument to this function is incorrect: Expected `DTGroup`, found `DTGroup | None`
- error[lint:invalid-argument-type] static_frame/test/property/strategies.py:811:21: Argument to this function is incorrect: Expected `(...) -> IndexHierarchy`, found `bound method type[Index].from_labels(labels: @Todo(specialized non-generic class), *, /, name: Unknown = None) -> I`
- error[lint:invalid-argument-type] static_frame/test/property/strategies.py:882:21: Argument to this function is incorrect: Expected `(...) -> IndexHierarchy`, found `bound method type[Index].from_labels(labels: @Todo(specialized non-generic class), *, /, name: Unknown = None) -> I`
- Found 5646 diagnostics
+ Found 5628 diagnostics

sphinx (https://github.com/sphinx-doc/sphinx)
- error[lint:unsupported-operator] sphinx/ext/autodoc/__init__.py:268:21: Operator `not in` is not supported for types `Unknown` and `None`, in comparing `Unknown` with `@Todo(specialized non-generic class) | None`
- error[lint:unsupported-operator] sphinx/ext/extlinks.py:115:25: Operator `%` is unsupported between objects of type `str | None` and `str`
- Found 781 diagnostics
+ Found 779 diagnostics

aiohttp (https://github.com/aio-libs/aiohttp)
- warning[lint:possibly-unbound-attribute] aiohttp/pytest_plugin.py:250:37: Attribute `EventLoopPolicy` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] aiohttp/resolver.py:91:26: Attribute `DNSResolver` on type `Unknown | None` is possibly unbound
- Found 237 diagnostics
+ Found 235 diagnostics

pycryptodome (https://github.com/Legrandin/pycryptodome)
- warning[lint:possibly-unbound-attribute] lib/Crypto/Cipher/AES.py:94:27: Attribute `AESNI_start_operation` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] lib/Crypto/Cipher/AES.py:95:26: Attribute `AESNI_stop_operation` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] lib/Crypto/Util/number.py:276:16: Attribute `getStrongPrime` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] lib/Crypto/Util/number.py:388:16: Attribute `isPrime` on type `Unknown | None` is possibly unbound
- Found 2261 diagnostics
+ Found 2257 diagnostics

cloud-init (https://github.com/canonical/cloud-init)
- error[lint:invalid-return-type] cloudinit/url_helper.py:782:16: Return type does not match returned value: Expected `int | float`, found `int | float | None`
- error[lint:call-non-callable] cloudinit/url_helper.py:880:51: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] tests/unittests/sources/test_gce.py:117:30: Attribute `keys` on type `Unknown | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/unittests/sources/test_gce.py:118:42: Method `__getitem__` of type `Unknown | None` is possibly unbound
- Found 744 diagnostics
+ Found 740 diagnostics

openlibrary (https://github.com/internetarchive/openlibrary)
- error[lint:call-non-callable] openlibrary/core/helpers.py:92:24: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] openlibrary/data/db.py:124:17: Attribute `get_multi` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] openlibrary/data/db.py:219:16: Attribute `set_multi` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] openlibrary/plugins/upstream/account.py:929:64: Object of type `None` is not callable
- error[lint:call-non-callable] openlibrary/plugins/upstream/account.py:929:64: Object of type `None` is not callable
- error[lint:call-non-callable] openlibrary/plugins/upstream/account.py:929:64: Object of type `None` is not callable
- error[lint:call-non-callable] openlibrary/plugins/upstream/account.py:931:39: Object of type `None` is not callable
- error[lint:unsupported-operator] openlibrary/utils/bulkimport.py:346:31: Operator `not in` is not supported for types `Unknown` and `None`, in comparing `(Unknown & ~AlwaysTruthy) | Unknown` with `Unknown | None`
- Found 818 diagnostics
+ Found 810 diagnostics

setuptools (https://github.com/pypa/setuptools)
- warning[lint:possibly-unbound-attribute] setuptools/_vendor/autocommand/autoasync.py:130:13: Attribute `create_task` on type `AbstractEventLoop | Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] setuptools/_vendor/autocommand/autoasync.py:133:13: Attribute `run_forever` on type `AbstractEventLoop | Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] setuptools/_vendor/autocommand/autoasync.py:135:20: Attribute `run_until_complete` on type `AbstractEventLoop | Unknown | None` is possibly unbound
- error[lint:call-non-callable] setuptools/compat/py311.py:25:13: Object of type `None` is not callable
- Found 1285 diagnostics
+ Found 1281 diagnostics

paasta (https://github.com/yelp/paasta)
- warning[lint:possibly-unbound-attribute] paasta_tools/api/api.py:279:9: Attribute `config` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] paasta_tools/api/tweens/request_logger.py:74:13: Attribute `log_line` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] paasta_tools/oom_logger.py:245:9: Attribute `events` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] paasta_tools/oom_logger.py:249:19: Attribute `create_counter` on type `Unknown | None` is possibly unbound
- Found 1066 diagnostics
+ Found 1062 diagnostics

bokeh (https://github.com/bokeh/bokeh)
- error[lint:unsupported-operator] src/bokeh/core/property/wrappers.py:501:49: Operator `>` is not supported for types `int` and `None`, in comparing `int` with `int | None`
- error[lint:unsupported-operator] src/bokeh/core/property/wrappers.py:502:34: Operator `-` is unsupported between objects of type `int` and `int | None`
- error[lint:invalid-argument-type] src/bokeh/core/validation/decorators.py:80:48: Argument to this function is incorrect: Expected `int`, found `int | str | Issue`
- error[lint:invalid-assignment] src/bokeh/core/validation/decorators.py:85:17: Object of type `int | str | Issue` is not assignable to `Issue`
- error[lint:call-non-callable] src/bokeh/resources.py:634:20: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] src/bokeh/server/views/ws.py:254:21: Attribute `received` on type `MessageTestPort | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] src/bokeh/server/views/ws.py:283:17: Attribute `sent` on type `MessageTestPort | None` is possibly unbound
- error[lint:no-matching-overload] src/bokeh/sphinxext/bokeh_plot.py:337:12: No overload of bound method `replace` matches arguments
- error[lint:invalid-argument-type] src/bokeh/util/logconfig.py:65:36: Argument to this function is incorrect: Expected `Handler`, found `Handler | None`
- Found 1921 diagnostics
+ Found 1912 diagnostics

streamlit (https://github.com/streamlit/streamlit)
- warning[lint:call-possibly-unbound-method] lib/streamlit/config.py:350:13: Method `__getitem__` of type `dict[str, Unknown] | None` is possibly unbound
- error[lint:unsupported-operator] lib/streamlit/config.py:1334:8: Operator `not in` is not supported for types `str` and `None`, in comparing `str` with `dict[str, Unknown] | None`
- warning[lint:call-possibly-unbound-method] lib/streamlit/config.py:1346:9: Method `__getitem__` of type `dict[str, Unknown] | None` is possibly unbound
- error[lint:call-non-callable] lib/streamlit/elements/widgets/button_group.py:859:27: Object of type `None` is not callable
- error[lint:unsupported-operator] lib/streamlit/runtime/forward_msg_queue.py:151:36: Operator `not in` is not supported for types `Unknown` and `None`, in comparing `Unknown` with `@Todo(specialized non-generic class) | None`
- Found 4292 diagnostics
+ Found 4287 diagnostics

apprise (https://github.com/caronc/apprise)
- error[lint:not-iterable] apprise/persistent_store.py:1250:37: Object of type `Unknown | None | list` may not be iterable
- error[lint:unsupported-operator] apprise/persistent_store.py:1253:38: Operator `in` is not supported for types `@Todo(Support for `typing.Self`)` and `None`, in comparing `@Todo(Support for `typing.Self`)` with `Unknown | None | list`
- Found 3624 diagnostics
+ Found 3622 diagnostics

rotki (https://github.com/rotki/rotki)
- warning[lint:possibly-unbound-attribute] rotkehlchen/tests/api/test_history_base_entry.py:104:31: Attribute `items` on type `dict[str, Any] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] rotkehlchen/tests/api/test_history_base_entry.py:104:31: Attribute `items` on type `dict[str, Any] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] rotkehlchen/tests/api/test_history_base_entry.py:104:31: Attribute `items` on type `dict[str, Any] | None` is possibly unbound
- error[lint:unsupported-operator] rotkehlchen/tests/utils/blockchain.py:189:45: Operator `in` is not supported for types `str` and `None`, in comparing `Literal["beaconchain"]` with `@Todo(specialized non-generic class) | None`
- error[lint:unsupported-operator] rotkehlchen/tests/utils/blockchain.py:644:38: Operator `in` is not supported for types `@Todo(map_with_boundness: intersections with negative contributions)` and `None`, in comparing `@Todo(map_with_boundness: intersections with negative contributions)` with `@Todo(specialized non-generic class) | None`
- Found 2243 diagnostics
+ Found 2238 diagnostics

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- error[lint:call-non-callable] ddtrace/contrib/internal/celery/app.py:100:33: Object of type `None` is not callable
- error[lint:call-non-callable] ddtrace/contrib/internal/kafka/patch.py:322:15: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/kafka/patch.py:322:44: Attribute `KEY` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:131:41: Attribute `OpenAI` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:133:41: Attribute `llms` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:145:41: Attribute `ChatOpenAI` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:147:41: Attribute `chat_models` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:159:41: Attribute `PineconeVectorStore` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:161:41: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:704:42: Attribute `output_parsers` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:957:20: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:960:30: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:964:21: Attribute `__name__` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:969:30: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:973:21: Attribute `__name__` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:978:20: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:981:30: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:985:21: Attribute `__name__` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1000:20: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1002:30: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1005:32: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1007:30: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1010:32: Attribute `embeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1012:20: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1014:30: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1017:32: Attribute `vectorstores` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1118:16: Attribute `OpenAIEmbeddings` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/contrib/internal/langchain/patch.py:1120:16: Attribute `PineconeVectorStore` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] ddtrace/contrib/internal/pylibmc/addrs.py:14:12: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] ddtrace/errortracking/_handled_exceptions/bytecode_reporting.py:113:9: Attribute `instrument_module_conditionally` on type `HandledExceptionReportingInjector | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/internal/core/__init__.py:375:44: Attribute `current_root_span` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] ddtrace/internal/datastreams/kafka.py:59:13: Object of type `None` is not callable
- error[lint:call-non-callable] ddtrace/internal/module.py:57:16: Object of type `None` is not callable
- error[lint:not-iterable] ddtrace/internal/utils/retry.py:26:22: Object of type `repeat[Unknown] | int | float | @Todo(specialized non-generic class)` may not be iterable
- warning[lint:possibly-unbound-attribute] ddtrace/internal/wrapping/asyncs.py:552:27: Attribute `bind` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/internal/wrapping/generators.py:397:23: Attribute `bind` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] ddtrace/profiling/_asyncio.py:96:12: Attribute `get_object` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] ddtrace/vendor/psutil/__init__.py:1639:21: Object of type `None` is not callable
- error[lint:invalid-argument-type] ddtrace/vendor/psutil/_common.py:403:30: Argument to this function is incorrect: Expected `int`, found `@Todo(Attribute access on enum classes) | None`
- warning[lint:possibly-unbound-attribute] scripts/diff.py:108:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] scripts/diff.py:109:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] scripts/diff.py:144:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] scripts/diff.py:145:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] scripts/diff.py:160:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] scripts/diff.py:161:13: Attribute `debug` on type `Logger | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/appsec/contrib_appsec/utils.py:385:24: Method `__getitem__` of type `Unknown | None` is possibly unbound
+ warning[lint:call-possibly-unbound-method] tests/appsec/contrib_appsec/utils.py:385:24: Method `__getitem__` of type `@Todo(map_with_boundness: intersections with negative contributions) | None` is possibly unbound
- warning[lint:call-possibly-unbound-method] tests/appsec/contrib_appsec/utils.py:386:28: Method `__getitem__` of type `Unknown | None` is possibly unbound
+ warning[lint:call-possibly-unbound-method] tests/appsec/contrib_appsec/utils.py:386:28: Method `__getitem__` of type `@Todo(map_with_boundness: intersections with negative contributions) | None` is possibly unbound
- error[lint:invalid-argument-type] tests/ci_visibility/util.py:95:56: Argument to this function is incorrect: Expected `set`, found `Unknown | None`
- Found 8774 diagnostics
+ Found 8728 diagnostics

jax (https://github.com/google/jax)
- error[lint:invalid-argument-type] jax/_src/api.py:1095:43: Argument to this function is incorrect: Expected `Sized`, found `int | None | @Todo(specialized non-generic class)`
- error[lint:invalid-argument-type] jax/_src/api.py:1098:39: Argument to this function is incorrect: Expected `Sized`, found `int | None | @Todo(specialized non-generic class)`
- warning[lint:possibly-unbound-attribute] jax/_src/buffer_callback.py:140:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/buffer_callback.py:140:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/buffer_callback.py:140:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/compilation_cache.py:186:18: Attribute `ZstdCompressor` on type `Unknown | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/compilation_cache.py:193:20: Attribute `ZstdDecompressor` on type `Unknown | None` is possibly unbound
- error[lint:call-non-callable] jax/_src/config.py:604:7: Object of type `None` is not callable
- warning[lint:possibly-unbound-attribute] jax/_src/custom_partitioning_sharding_rule.py:210:7: Attribute `append` on type `@Todo(specialized non-generic class) | None` is possibly unbound
- error[lint:invalid-argument-type] jax/_src/ffi.py:457:14: Argument to this function is incorrect: Expected `Sized`, found `@Todo(specialized non-generic class) | None`
- error[lint:invalid-argument-type] jax/_src/ffi.py:460:45: Argument to this function is incorrect: Expected `Sized`, found `@Todo(specialized non-generic class) | None`
- error[lint:invalid-argument-type] jax/_src/ffi.py:467:14: Argument to this function is incorrect: Expected `Sized`, found `@Todo(specialized non-generic class) | None`
- error[lint:invalid-argument-type] jax/_src/ffi.py:470:46: Argument to this function is incorrect: Expected `Sized`, found `@Todo(specialized non-generic class) | None`
- warning[lint:possibly-unbound-attribute] jax/_src/ffi.py:476:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/ffi.py:476:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- warning[lint:possibly-unbound-attribute] jax/_src/ffi.py:476:34: Attribute `items` on type `dict[int, int] | None` is possibly unbound
- error[lint:not-iterable] jax/_src/lax/linalg.py:2825:57: Object of type ...*[Comment body truncated]*

carljm

Thank you for this PR! This is a very valuable feature, and it is clearly impactful in the ecosystem checks -- from what I can tell, it removes a lot of false positives.

I do have some questions about the implementation; it feels very "layered on top", as if it tries to only add new code and avoid touching existing code, and it seems like this results in some avoidable duplication (both of logic, and of real runtime work).

crates/red_knot_python_semantic/src/semantic_index/builder.rs

crates/red_knot_python_semantic/src/semantic_index/use_def.rs

crates/red_knot_python_semantic/src/types/narrow.rs

crates/red_knot_python_semantic/src/semantic_index/builder.rs

crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/nested.md

crates/red_knot_python_semantic/src/types/infer.rs

codspeed-hq · 2025-05-01T17:45:10Z

CodSpeed Performance Report

Merging #17630 will not alter performance

_{Comparing mtshiba:nested-narrowing (9e04457) with main (ada4c4c)}

Summary

✅ 33 untouched benchmarks

carljm

Looking good! It still seems to me like we are doing more work than necessary here, and if we do less we may be able to reduce the regression.

crates/red_knot_python_semantic/src/semantic_index/builder.rs

crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/nested.md

crates/red_knot_python_semantic/src/semantic_index/use_def/symbol_state.rs

crates/red_knot_python_semantic/src/semantic_index/builder.rs

crates/red_knot_python_semantic/src/types/infer.rs

crates/red_knot_python_semantic/src/types/narrow.rs

crates/red_knot_python_semantic/src/semantic_index/builder.rs

MichaReiser · 2025-05-03T17:55:28Z

@mtshiba I rebased your PR passed the Red Knot renaming. Make sure to pull before making new commits.

…use` have a value only at a class scope

carljm · 2025-05-05T23:28:29Z

Thank you, this looks great! I thought of one bug while reviewing, but I went ahead and just fixed it, along with some other cleanups. (The bug was that in a class scope, although we do need to preserve the narrowing constraints that applied to "unbound", even if "unbound" becomes not-visible, new narrowing checks after unbound becomes not-visible do not apply, as they aren't narrowing the outer-scope value we will see in nested scopes, they are narrowing only the local bindings we don't see.)

After rebasing on top of the signature cycles fix, everything is passing in CI and ecosystem results still look good. Going ahead and landing this!

This PR fixes astral-sh#17595. New test cases are added to `mdtest/narrow/conditionals/nested.md`. --------- Co-authored-by: Carl Meyer <[email protected]>

mtshiba requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners April 25, 2025 15:33

mtshiba mentioned this pull request Apr 25, 2025

Support narrowing on attribute and subscript expressions astral-sh/ty#164

Closed

AlexWaygood added the ty Multi-file analysis & type inference label Apr 28, 2025

carljm reviewed Apr 28, 2025

View reviewed changes

AlexWaygood removed their request for review April 28, 2025 18:42

mtshiba force-pushed the nested-narrowing branch from 866e55f to 13d58d2 Compare April 30, 2025 12:49

carljm reviewed May 2, 2025

View reviewed changes

mtshiba force-pushed the nested-narrowing branch from 92150b9 to 4d634d3 Compare May 2, 2025 16:55

mtshiba requested a review from carljm May 2, 2025 17:34

carljm reviewed May 2, 2025

View reviewed changes

crates/red_knot_python_semantic/src/semantic_index/builder.rs Outdated Show resolved Hide resolved

MichaReiser force-pushed the nested-narrowing branch from 3243b02 to dda49b6 Compare May 3, 2025 17:55

mtshiba and others added 12 commits May 5, 2025 16:10

[red-knot] fix narrowing in nested scopes

4fed60a

improve documents

a8a474f

fix handling of global symbol narrowing

c2566b7

avoid walking scopes twice

5814782

add UseDefMap::narrowing_constraints_at_use

e3063a4

avoid extra costs by making `SymbolBindings::narrowing_constraint_at_…

343b442

…use` have a value only at a class scope

add UseDefMapBuilder::used_names

9c5086a

Update infer.rs

3ba9f73

add SymbolBindings::narrowing_constraint

75d446d

save a narrowing constraint or eager bindings as an EagerSnapshot

e9d7779

comment and visibility cleanup

f11ce89

fix class-scope bug, remove try_ use ID APIs

b54a293

carljm force-pushed the nested-narrowing branch from dda49b6 to b54a293 Compare May 5, 2025 23:12

allow -> expect

9e04457

carljm merged commit fd76d70 into astral-sh:main May 5, 2025
35 of 36 checks passed

mtshiba deleted the nested-narrowing branch May 7, 2025 16:03

Comments

Conversation

mtshiba commented Apr 25, 2025

Summary

Test Plan

Uh oh!

github-actions bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #17630 will not alter performance

Summary

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaReiser commented May 3, 2025

Uh oh!

carljm commented May 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 25, 2025 •

edited

Loading

`mypy_primer` results

codspeed-hq bot commented May 1, 2025 •

edited

Loading