[airflow] Refactor AIR301 logic and fix typos (AIR301)#17293
Merged
ntBre merged 3 commits intoastral-sh:mainfrom Apr 9, 2025
Merged
[airflow] Refactor AIR301 logic and fix typos (AIR301)#17293ntBre merged 3 commits intoastral-sh:mainfrom
airflow] Refactor AIR301 logic and fix typos (AIR301)#17293ntBre merged 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR301 | 19 | 0 | 19 | 0 | 0 |
Lee-W
changed the title
Contributor
Author
|
The TODOs are intentionally kept. They're things I think might be outdated but I'll need to confirm with the airflow community. Also, I would like to keep this PR simple |
ntBre
approved these changes
Apr 8, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! A couple of questions, but this looks good otherwise.
Contributor
|
Is this ready to merge? |
Contributor
Author
Yep, this is ready 🙂 |
ntBre
approved these changes
Apr 9, 2025
ntBre
changed the title
airflow] Refactor AIR301 logic and fix typos (AIR301)
ntBre
added
documentation
dcreager
added a commit
that referenced
this pull request
Apr 9, 2025
* main: [red-knot] Allow explicit specialization of generic classes (#17023) [`airflow`] Refactor `AIR301` logic and fix typos (`AIR301`) (#17293) [`airflow`] Extract `AIR312` from `AIR302` rules (`AIR302`, `AIR312`) (#17152) [red-knot] Improve handling of visibility constraints in external modules when resolving `*` imports (#17286) [red-knot] Add more tests for `*` imports (#17315)
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 9, 2025
…sh#17293) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> * Simplify match conditions in AIR301 * Fix * `airflow.datasets.manager.DatasetManager` → `airflow.assets.manager.AssetManager` * `airflow.www.auth.has_access_dataset` → `airflow.www.auth.has_access_dataset` ## Test Plan <!-- How was it tested? --> The test fixture has been updated accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
airflow.datasets.manager.DatasetManager→airflow.assets.manager.AssetManagerairflow.www.auth.has_access_dataset→airflow.www.auth.has_access_datasetTest Plan
The test fixture has been updated accordingly