Conversation
Summary -- Updates `fuzz.py` to run with `--preview`, which should allow it to catch semantic syntax errors. Test Plan -- @AlexWaygood and I temporarily made any named expression a semantic syntax error and checked that this led to fuzzing errors. We also tested that reverting the `--preview` addition did not show any errors. We also ran the fuzzer on 500 seeds on `main` but didn't find any issues, (un)fortunately.
MichaReiser
approved these changes
Apr 4, 2025
Contributor
|
AlexWaygood
approved these changes
Apr 4, 2025
dcreager
added a commit
that referenced
this pull request
Apr 4, 2025
* main: [red-knot] Empty tuple is always-falsy (#17213) Run fuzzer with `--preview` (#17210) Bump 0.11.4 (#17212) [syntax-errors] Allow `yield` in base classes and annotations (#17206) Don't skip visiting non-tuple slice in `typing.Annotated` subscripts (#17201) [red-knot] mypy_primer: do not specify Python version (#17200) [red-knot] Add `Type.definition` method (#17153) Implement `Invalid rule provided` as rule RUF102 with `--fix` (#17138) [red-knot] Add basic on-hover to playground and LSP (#17057) [red-knot] don't remove negations when simplifying constrained typevars (#17189) [minor] Fix extra semicolon for clippy (#17188) [syntax-errors] Invalid syntax in annotations (#17101) [syntax-errors] Duplicate attributes in match class pattern (#17186) [syntax-errors] Fix multiple assignment for class keyword argument (#17184) use astral-sh/cargo-dist instead (#17187) Enable overindented docs lint (#17182)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
fuzz.pyto run with--preview, which should allow it to catch semantic syntax errors.Test Plan
@AlexWaygood and I temporarily made any named expression a semantic syntax error and checked that this led to fuzzing errors. We also tested that reverting the
--previewaddition did not show any errors.We also ran the fuzzer on 500 seeds on
mainbut didn't find any issues, (un)fortunately.