[red-knot] Move tuple containing Never tests#17137
Merged
dhruvmanila merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
dhruvmanila
added
internal
dhruvmanila
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
dhruvmanila
force-pushed
the
dhruv/move-test
branch
from
f8c73d1 to
f2a3eaf
Compare
sharkdp
reviewed
Apr 2, 2025
Comment on lines
+23
to
+26
| def _(x: tuple[Never], y: tuple[int, Never], z: tuple[Never, int]): | ||
| reveal_type(x) # revealed: Never | ||
| reveal_type(y) # revealed: Never | ||
| reveal_type(z) # revealed: Never |
Contributor
There was a problem hiding this comment.
Not that it's particularly important, but do these really test something other than the assertions in lines 16-18?
Member
There was a problem hiding this comment.
I see your point, but IMO it "says the same thing in a different way", and I think that can be valuable for human readers of the test
Member
Author
There was a problem hiding this comment.
To add to that, I'd say it's testing the "simplified to Never" part specifically and more precisely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer #17094 (comment)