CI: Run pre-commit on depot machine#17120
Conversation
akx
force-pushed
the
ci-chonkier-pre-commit-machines
branch
from
cdd25c8 to
9e6f66b
Compare
|
@AlexWaygood The numbers are in (reran this PR and #17108 to warm caches):
|
|
Woah, nice -- that definitely seems worth it to me! |
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you! Considering that pre-commit is a required job for automerge to succeed, I'm pretty sure that it's worth it to use the beefier runner here
|
|
I'm also positively surprised by the speedup. I had a hunch that GHA's machines are slow, but not that slow... The Depot machines are https://depot.dev/, yeah? |
not sure, but that looks plausible! |
* main: [red-knot] Add property tests for callable types (#17006) [red-knot] Disjointness for callable types (#17094) [red-knot] Flatten `Type::Callable` into four `Type` variants (#17126) mdtest.py: do a full mdtest run immediately when the script is executed (#17128) [red-knot] Fix callable subtyping for standard parameters (#17125) [red-knot] Fix more `redundant-cast` false positives (#17119) Sync vendored typeshed stubs (#17106) [red-knot] support Any as a class in typeshed (#17107) Visit `Identifier` node as part of the `SourceOrderVisitor` (#17110) [red-knot] Don't infer Todo for quite so many tuple type expressions (#17116) CI: Run pre-commit on depot machine (#17120) Error instead of `panic!` when running Ruff from a deleted directory (#16903) (#17054) Control flow graph: setup (#17064) [red-knot] Playground improvements (#17109) [red-knot] IDE crate (#17045) Update dependency vite to v6.2.4 (#17104) [red-knot] Add redundant-cast error (#17100) [red-knot] Narrowing on `in tuple[...]` and `in str` (#17059)
2 participants
Summary
Sibling/alternate of #17108 (see #17108 (comment)).
See if running the pre-commit CI step on Depot machines makes WASM-compiled shellcheck faster.
Test Plan
We're doing it live!