Visit Identifier node as part of the SourceOrderVisitor#17110
Merged
MichaReiser merged 1 commit intomainfrom Apr 1, 2025
Merged
Visit Identifier node as part of the SourceOrderVisitor#17110MichaReiser merged 1 commit intomainfrom
Identifier node as part of the SourceOrderVisitor#17110MichaReiser merged 1 commit intomainfrom
Conversation
Contributor
|
Member
Author
|
Yeah, I was too lazy to also change Visitor but I think we could (we just need to be careful and review the call sites to skip visiting if it can change behavior). But you can also just use the |
dcreager
added a commit
that referenced
this pull request
Apr 1, 2025
* main: [red-knot] Add property tests for callable types (#17006) [red-knot] Disjointness for callable types (#17094) [red-knot] Flatten `Type::Callable` into four `Type` variants (#17126) mdtest.py: do a full mdtest run immediately when the script is executed (#17128) [red-knot] Fix callable subtyping for standard parameters (#17125) [red-knot] Fix more `redundant-cast` false positives (#17119) Sync vendored typeshed stubs (#17106) [red-knot] support Any as a class in typeshed (#17107) Visit `Identifier` node as part of the `SourceOrderVisitor` (#17110) [red-knot] Don't infer Todo for quite so many tuple type expressions (#17116) CI: Run pre-commit on depot machine (#17120) Error instead of `panic!` when running Ruff from a deleted directory (#16903) (#17054) Control flow graph: setup (#17064) [red-knot] Playground improvements (#17109) [red-knot] IDE crate (#17045) Update dependency vite to v6.2.4 (#17104) [red-knot] Add redundant-cast error (#17100) [red-knot] Narrowing on `in tuple[...]` and `in str` (#17059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I don't remember exactly when we made
Identifiera node but it is now considered a node (it implementsAnyNodeRef, it has a range). However, we never updatedthe
SourceOrderVisitorto visit identifiers because we never had a use case for it and visiting new nodes can change how the formatter associates comments (breaking change!).This PR updates the
SourceOrderVisitorto visit identifiers and changes the formatter comment visitor to skip identifiers (updating the visitor might be desired because it could help simplifying some comment placement logic but this is out of scope for this PR).Test Plan
Tests, updated snapshot tests