[red-knot] Disjointness for callable types#17094
Merged
dhruvmanila merged 2 commits intomainfrom Apr 1, 2025
Merged
Conversation
19 tasks
Contributor
|
dhruvmanila
force-pushed
the
dhruv/callable-disjoint
branch
2 times, most recently
from
ce725c5 to
beb8d94
Compare
dhruvmanila
commented
Mar 31, 2025
Comment on lines
83
to
92
| If a tuple type contains a `Never` element, it is considered similar to `Never` itself and is | ||
| disjoint from any other type. | ||
|
|
||
| ```py | ||
| static_assert(is_disjoint_from(tuple[Never], tuple[Never])) | ||
| static_assert(is_disjoint_from(tuple[int, Never], tuple[int, Never])) | ||
| static_assert(is_disjoint_from(tuple[int, Never], tuple[Never, int])) | ||
| static_assert(is_disjoint_from(tuple[int, Never], tuple[int, int])) | ||
| ``` | ||
|
|
Member
Author
There was a problem hiding this comment.
This is not related to this PR but it helped my understanding when I discussed Never usage with Alex and David last week so I added some test cases for it as they were missing.
dhruvmanila
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
dcreager
reviewed
Apr 1, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Apr 1, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Apr 1, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice, this looks great. A couple of small points
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Show resolved
Hide resolved
carljm
approved these changes
Apr 1, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
Outdated
Show resolved
Hide resolved
dhruvmanila
force-pushed
the
dhruv/callable-disjoint
branch
2 times, most recently
from
ffca69f to
60b3189
Compare
dhruvmanila
force-pushed
the
dhruv/callable-disjoint
branch
from
60b3189 to
3544413
Compare
dcreager
added a commit
that referenced
this pull request
Apr 1, 2025
* main: [red-knot] Add property tests for callable types (#17006) [red-knot] Disjointness for callable types (#17094) [red-knot] Flatten `Type::Callable` into four `Type` variants (#17126) mdtest.py: do a full mdtest run immediately when the script is executed (#17128) [red-knot] Fix callable subtyping for standard parameters (#17125) [red-knot] Fix more `redundant-cast` false positives (#17119) Sync vendored typeshed stubs (#17106) [red-knot] support Any as a class in typeshed (#17107) Visit `Identifier` node as part of the `SourceOrderVisitor` (#17110) [red-knot] Don't infer Todo for quite so many tuple type expressions (#17116) CI: Run pre-commit on depot machine (#17120) Error instead of `panic!` when running Ruff from a deleted directory (#16903) (#17054) Control flow graph: setup (#17064) [red-knot] Playground improvements (#17109) [red-knot] IDE crate (#17045) Update dependency vite to v6.2.4 (#17104) [red-knot] Add redundant-cast error (#17100) [red-knot] Narrowing on `in tuple[...]` and `in str` (#17059)
sharkdp
reviewed
Apr 1, 2025
dhruvmanila
added a commit
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #15382, this PR adds support for disjointness between two callable types. They are never disjoint because there exists a callable type that's a subtype of all other callable types:
The
Neveris a subtype of every fully static type thus a callable type that has the return type ofNevermeans that it is a subtype of every return type.Test Plan
Add test cases related to mixed parameter kinds, gradual form (
...) andNevertype.