[airflow] Extend AIR302 with additional symbols#17085
Merged
dhruvmanila merged 8 commits intoastral-sh:mainfrom Apr 2, 2025
Merged
[airflow] Extend AIR302 with additional symbols#17085dhruvmanila merged 8 commits intoastral-sh:mainfrom
airflow] Extend AIR302 with additional symbols#17085dhruvmanila merged 8 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR302 | 21 | 21 | 0 | 0 | 0 |
fc5eda9 to
f1dbda8
Compare
dhruvmanila
requested changes
Mar 31, 2025
1cbdd9e to
e2a13d0
Compare
Closed
6 tasks
e2a13d0 to
ba89eeb
Compare
…ink → airflow.sdk.definitions.baseoperatorlink.BaseOperatorLink"
* ``airflow.auth.managers.base_auth_manager.is_authorized_dataset`` → ``airflow.api_fastapi.auth.managers.base_auth_manager.is_authorized_asset`` * ``airflow.auth.managers.models.resource_details.DatasetDetails`` → ``airflow.api_fastapi.auth.managers.models.resource_details.AssetDetails`` * Dag arguments default_view and orientation removed
* ``airflow.notifications.basenotifier.BaseNotifier`` → ``airflow.sdk.BaseNotifier`` * ``airflow.utils.log.secrets_masker`` → ``airflow.sdk.execution_time.secrets_masker``
…ow_future_exec_dates``
…nsorOperator → airflow.sdk.bases.sensor.BaseSensorOperator"
ba89eeb to
ce6d69c
Compare
dhruvmanila
approved these changes
Apr 2, 2025
airflow] Extend AIR302 with additional symbols
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (35 commits) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) [`airflow`] Move `AIR301` to `AIR002` (#16978) [`airflow`] Add autofix for `AIR302` method checks (#16976) ruff_db: switch diagnostic rendering over to `std::fmt::Display` [red-knot] Add 'Goto type definition' to the playground (#17055) red_knot_ide: update snapshots red_knot_python_semantic: remove comment about `TypeCheckDiagnostic` ruff_db: delete most of the old diagnostic code red_knot: use `Diagnostic` inside of red knot ...
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (82 commits) [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) ...
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
## Summary
* ``airflow.auth.managers.base_auth_manager.is_authorized_dataset`` has
been moved to
``airflow.api_fastapi.auth.managers.base_auth_manager.is_authorized_asset``
in Airflow 3.0
* ``airflow.auth.managers.models.resource_details.DatasetDetails`` has
been moved to
``airflow.api_fastapi.auth.managers.models.resource_details.AssetDetails``
in Airflow 3.0
* Dag arguments `default_view` and `orientation` has been removed in
Airflow 3.0
* `airflow.models.baseoperatorlink.BaseOperatorLink` has been moved to
`airflow.sdk.definitions.baseoperatorlink.BaseOperatorLink` in Airflow
3.0
* ``airflow.notifications.basenotifier.BaseNotifier`` has been moved to
``airflow.sdk.BaseNotifier`` in Airflow 3.0
* ``airflow.utils.log.secrets_masker`` has been moved to
``airflow.sdk.execution_time.secrets_masker`` in Airflow 3.0
* ``airflow...DAG.allow_future_exec_dates`` has been removed in Airflow
3.0
* `airflow.utils.db.create_session` has een removed in Airflow 3.0
* `airflow.sensors.base_sensor_operator.BaseSensorOperator` has been
moved to `airflow.sdk.bases.sensor.BaseSensorOperator` removed Airflow
3.0
* `airflow.utils.file.TemporaryDirectory` has been removed in Airflow
3.0 and can be replaced by `tempfile.TemporaryDirectory`
* `airflow.utils.file.mkdirs` has been removed in Airflow 3.0 and can be
replaced by `pathlib.Path({path}).mkdir`
## Test Plan
Test fixture has been added for these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
airflow.auth.managers.base_auth_manager.is_authorized_datasethas been moved toairflow.api_fastapi.auth.managers.base_auth_manager.is_authorized_assetin Airflow 3.0airflow.auth.managers.models.resource_details.DatasetDetailshas been moved toairflow.api_fastapi.auth.managers.models.resource_details.AssetDetailsin Airflow 3.0default_viewandorientationhas been removed in Airflow 3.0airflow.models.baseoperatorlink.BaseOperatorLinkhas been moved toairflow.sdk.definitions.baseoperatorlink.BaseOperatorLinkin Airflow 3.0airflow.notifications.basenotifier.BaseNotifierhas been moved toairflow.sdk.BaseNotifierin Airflow 3.0airflow.utils.log.secrets_maskerhas been moved toairflow.sdk.execution_time.secrets_maskerin Airflow 3.0airflow...DAG.allow_future_exec_dateshas been removed in Airflow 3.0airflow.utils.db.create_sessionhas een removed in Airflow 3.0airflow.sensors.base_sensor_operator.BaseSensorOperatorhas been moved toairflow.sdk.bases.sensor.BaseSensorOperatorremoved Airflow 3.0airflow.utils.file.TemporaryDirectoryhas been removed in Airflow 3.0 and can be replaced bytempfile.TemporaryDirectoryairflow.utils.file.mkdirshas been removed in Airflow 3.0 and can be replaced bypathlib.Path({path}).mkdirTest Plan
Test fixture has been added for these changes