[red-knot] visibility_constraint analysis for match cases#17077
Merged
AlexWaygood merged 12 commits intoastral-sh:mainfrom Apr 3, 2025
Merged
[red-knot] visibility_constraint analysis for match cases#17077AlexWaygood merged 12 commits intoastral-sh:mainfrom
AlexWaygood merged 12 commits intoastral-sh:mainfrom
Conversation
Contributor
|
2a7a2ae to
a7f0153
Compare
AlexWaygood
reviewed
Mar 31, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice! Not a full review, but I spotted something in one branch that I suspect could apply to some of the other branches, so I'll hold off on making further comments until that's addressed.
Overall this looks great, though -- thank you!
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Show resolved
Hide resolved
AlexWaygood
reviewed
Apr 1, 2025
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Show resolved
Hide resolved
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Outdated
Show resolved
Hide resolved
carljm
reviewed
Apr 1, 2025
Contributor
carljm
left a comment
There was a problem hiding this comment.
This is excellent work, thank you!!
crates/red_knot_python_semantic/resources/mdtest/conditional/match.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Show resolved
Hide resolved
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Show resolved
Hide resolved
crates/red_knot_python_semantic/src/semantic_index/visibility_constraints.rs
Show resolved
Hide resolved
a678d17 to
716708e
Compare
AlexWaygood
approved these changes
Apr 3, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you, this is great!
1061ec5 to
7d1d143
Compare
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165)
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (82 commits) [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) ...
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
…17077) ## Summary Add visibility constraint analysis for pattern predicate kinds `Singleton`, `Or`, and `Class`. ## Test Plan update conditional/match.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add visibility constraint analysis for pattern predicate kinds
Singleton,Or, andClass.Test Plan
update conditional/match.md