[airflow] Add autofix for AIR302 attribute checks#16977
Merged
dhruvmanila merged 2 commits intoastral-sh:mainfrom Apr 2, 2025
Merged
[airflow] Add autofix for AIR302 attribute checks#16977dhruvmanila merged 2 commits intoastral-sh:mainfrom
airflow] Add autofix for AIR302 attribute checks#16977dhruvmanila merged 2 commits intoastral-sh:mainfrom
Conversation
20 tasks
Contributor
|
Lee-W
force-pushed
the
autofix-AIR302-check-class-attribute
branch
from
cc5b974 to
0f32ef4
Compare
Lee-W
force-pushed
the
autofix-AIR302-check-class-attribute
branch
2 times, most recently
from
6df9ce8 to
d8ac9a8
Compare
dhruvmanila
added
fixes
dhruvmanila
approved these changes
Mar 31, 2025
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Looks good, once the clone is removed I'll merge this and the other PR (#16976).
dhruvmanila
changed the title
airflow] Add autofix AIR302 attribute checks
Lee-W
force-pushed
the
autofix-AIR302-check-class-attribute
branch
2 times, most recently
from
5dfbd1f to
4677526
Compare
Member
|
@Lee-W You'd need to resolve the merge conflicts, I can't push to this branch directly as it's on the fork is under the Astronomer organization. |
Contributor
Author
Yep, I will. Sorry, I don't have the permission to change it either 😢 But I'll rebase it ASAP! |
Lee-W
force-pushed
the
autofix-AIR302-check-class-attribute
branch
from
4677526 to
1d78b03
Compare
Member
|
Thank you! |
dhruvmanila
changed the title
airflow] Add autofix AIR302 attribute checksairflow] Add autofix for AIR302 attribute checks
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (35 commits) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) [`airflow`] Move `AIR301` to `AIR002` (#16978) [`airflow`] Add autofix for `AIR302` method checks (#16976) ruff_db: switch diagnostic rendering over to `std::fmt::Display` [red-knot] Add 'Goto type definition' to the playground (#17055) red_knot_ide: update snapshots red_knot_python_semantic: remove comment about `TypeCheckDiagnostic` ruff_db: delete most of the old diagnostic code red_knot: use `Diagnostic` inside of red knot ...
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (82 commits) [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) ...
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
## Summary Add autofix logic to AIR302 check_method ## Test Plan test fixtures have been updated accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add autofix logic to AIR302 check_method
Test Plan
test fixtures have been updated accordingly