[red-knot] Fix panic on cyclic * imports#16958
Merged
AlexWaygood merged 1 commit intomainfrom Mar 24, 2025
Merged
Conversation
This was referenced Mar 24, 2025
AlexWaygood
force-pushed
the
alex/star-import-cycles
branch
from
b98bc8d to
a602ad1
Compare
carljm
reviewed
Mar 24, 2025
crates/red_knot_python_semantic/src/semantic_index/re_exports.rs
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/import/star.md
Outdated
Show resolved
Hide resolved
Contributor
|
AlexWaygood
force-pushed
the
alex/star-import-cycles
branch
from
a602ad1 to
ba1e19e
Compare
carljm
approved these changes
Mar 24, 2025
AlexWaygood
force-pushed
the
alex/star-import-cycles
branch
from
ba1e19e to
1629169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Further work towards #14169.
We currently panic on encountering cyclic
*imports. This is easily fixed using fixpoint iteration.Test Plan
Added a test that panics on
main, but passes with this PR