[red-knot] Fix gradual equivalence for callable types#16887
Merged
dhruvmanila merged 2 commits intomainfrom Mar 24, 2025
Merged
[red-knot] Fix gradual equivalence for callable types#16887dhruvmanila merged 2 commits intomainfrom
dhruvmanila merged 2 commits intomainfrom
Conversation
dhruvmanila
changed the title
Contributor
|
dhruvmanila
force-pushed
the
dhruv/callable-fix-gradual-equivalence
branch
from
d714765 to
f532589
Compare
dhruvmanila
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
carljm
approved these changes
Mar 24, 2025
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Looks great! I really like the pattern you've established of using a common function with a callback that implements the distinction between subtyping and assignability (or in this case, equivalence and gradual equivalence.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #16698 (comment), part of #15382, this PR updates the
is_gradual_equivalent_toimplementation between callable types to be similar tois_equivalent_toand checks other attributes of parameters like name, optionality, and parameter kind.Test Plan
Expand the existing test cases to consider other properties but not all similar to how the tests are structured for subtyping and assignability.