Skip to content

Comments

[ci] Test linter-only change#16800

Closed
MichaReiser wants to merge 1 commit intomicha/replace-changed-filesfrom
micha/test-linter-change
Closed

[ci] Test linter-only change#16800
MichaReiser wants to merge 1 commit intomicha/replace-changed-filesfrom
micha/test-linter-change

Conversation

@MichaReiser
Copy link
Member

Tests the changes in #16796 by making a linter only change.

It should skip the formatter specific pipelines but run the linter ecosystem checks.

@MichaReiser MichaReiser added ci Related to internal CI tooling do-not-merge Do not merge this pull request labels Mar 17, 2025
@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser added a commit that referenced this pull request Mar 17, 2025
## Summary

Use bash and `git diff` to determine which steps need to run. 

We previously used the `changed-files` github actions but using `git`
directly seems simple enough.

All credit for the bash magic goes to @zanieb and @geofft. All I did was
replace the paths arguments.


## Test Plan

* [Linter only change](#16800):
See how the fuzzer and formatter steps, and the linter ecosystem checks
are skipped
* [Formatter only change](#16799):
See how the fuzzer and linter ecosystem checks are skipped
@MichaReiser MichaReiser deleted the micha/test-linter-change branch May 3, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling do-not-merge Do not merge this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant