Test "determine-changes" step for formatter only change"#16799
Closed
MichaReiser wants to merge 1 commit intomicha/replace-changed-filesfrom
Closed
Test "determine-changes" step for formatter only change"#16799MichaReiser wants to merge 1 commit intomicha/replace-changed-filesfrom
MichaReiser wants to merge 1 commit intomicha/replace-changed-filesfrom
Conversation
MichaReiser
force-pushed
the
micha/formatter-change
branch
from
30466a5 to
36b389c
Compare
MichaReiser
force-pushed
the
micha/formatter-change
branch
from
36b389c to
1d3f890
Compare
Contributor
|
MichaReiser
force-pushed
the
micha/formatter-change
branch
from
1d3f890 to
51c3f60
Compare
MichaReiser
added a commit
that referenced
this pull request
Mar 17, 2025
## Summary Use bash and `git diff` to determine which steps need to run. We previously used the `changed-files` github actions but using `git` directly seems simple enough. All credit for the bash magic goes to @zanieb and @geofft. All I did was replace the paths arguments. ## Test Plan * [Linter only change](#16800): See how the fuzzer and formatter steps, and the linter ecosystem checks are skipped * [Formatter only change](#16799): See how the fuzzer and linter ecosystem checks are skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub actions should skip the ruff linter ecosystem check