Skip to content

Comments

[pygrep-hooks]: Detect file-level suppressions comments without rule codes (PGH004)#16699

Merged
MichaReiser merged 1 commit intomicha/ruff-0.10from
micha/blanked-noqa-file-level
Mar 13, 2025
Merged

[pygrep-hooks]: Detect file-level suppressions comments without rule codes (PGH004)#16699
MichaReiser merged 1 commit intomicha/ruff-0.10from
micha/blanked-noqa-file-level

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Mar 13, 2025

Summary

This PR stabilizes the preview behavior of PGH004 to also detect blanked file-level noqa comments (and not just line level comments).

This preview behavior was first released with Ruff 0.4.8 (June 2025). There are no open issues or PRs open related to this behavior.

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Mar 13, 2025
@MichaReiser MichaReiser requested review from dylwil3 and ntBre March 13, 2025 08:26
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16699 will degrade performances by 4.6%

Comparing micha/blanked-noqa-file-level (c1c0d1b) with micha/ruff-0.10 (d622137)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ red_knot_check_file[incremental] 5.2 ms 5.5 ms -4.6%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+5 -0 violations, +0 -0 fixes in 5 projects; 50 projects unchanged)

apache/airflow (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ docs/exts/exampleinclude.py:1:1: PGH004 Use specific rule codes when using `ruff: noqa`

apache/superset (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ tests/integration_tests/superset_test_config_sqllab_backend_persist_off.py:17:1: PGH004 Use specific rule codes when using `ruff: noqa`

pytest-dev/pytest (+1 -0 violations, +0 -0 fixes) 

+ testing/code/test_source.py:2:1: PGH004 Use specific rule codes when using `ruff: noqa`

pdm-project/pdm (+1 -0 violations, +0 -0 fixes) 

+ src/pdm/installers/__init__.py:1:1: PGH004 Use specific rule codes when using `ruff: noqa`

astropy/astropy (+1 -0 violations, +0 -0 fixes) 

+ astropy/io/ascii/__init__.py:3:1: PGH004 Use specific rule codes when using `ruff: noqa`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PGH004 5 5 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser force-pushed the micha/blanked-noqa-file-level branch from 1e89b3d to c1c0d1b Compare March 13, 2025 08:36
@MichaReiser MichaReiser added this to the v0.10 milestone Mar 13, 2025
@MichaReiser
Copy link
Member Author

MichaReiser commented Mar 13, 2025

The ecosystem checks are all true-positives

dylwil3
dylwil3 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@dylwil3 dylwil3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I do think that we should have a followup issue/PR where we add the feature that this rule has for inline suppressions where it tries to guess if you just forgot a colon

@MichaReiser MichaReiser mentioned this pull request Mar 13, 2025
Open
@MichaReiser MichaReiser merged commit 72ffa12 into micha/ruff-0.10 Mar 13, 2025
20 of 21 checks passed
@MichaReiser MichaReiser deleted the micha/blanked-noqa-file-level branch March 13, 2025 12:46
@MichaReiser MichaReiser mentioned this pull request Mar 13, 2025
Merged
2 tasks
@dylwil3 dylwil3 mentioned this pull request Mar 13, 2025
Closed
@MichaReiser MichaReiser restored the micha/blanked-noqa-file-level branch March 14, 2025 07:24
@MichaReiser MichaReiser mentioned this pull request Mar 14, 2025
Merged
MichaReiser added a commit that referenced this pull request Mar 14, 2025
@MichaReiser
[pygrep-hooks]: Detect file-level suppressions comments without rul… (
14c5ed5 
#16720)

## Summary

I accidentially dropped this commit from the Ruff 0.10 release. See
#16699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylwil3 dylwil3 dylwil3 approved these changes

@ntBre ntBre Awaiting requested review from ntBre

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

v0.10

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @dylwil3