[`pyupgrade`]: Deprecate `non-pep604-isinstance` (`UP038`) by MichaReiser · Pull Request #16681 · astral-sh/ruff

MichaReiser · 2025-03-12T15:42:19Z

Summary

This PR deprecates UP038. Using PEP 604 syntax in isinstance and issubclass calls isn't a recommended pattern (or community agreed best practice)
and it negatively impacts performance.

Resolves #7871

Test Plan

I tested that selecting UP038 results in a warning in no-preview mode and an error in preview mode

codspeed-hq · 2025-03-12T15:47:30Z

CodSpeed Performance Report

Merging #16681 will degrade performances by 4.61%

_{Comparing micha/deprecate-up038 (9511be4) with micha/ruff-0.10 (464ea4a)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
❌	`red_knot_check_file[incremental]`	5.2 ms	5.5 ms	-4.61%

github-actions · 2025-03-12T15:48:47Z

`ruff-ecosystem` results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -39 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/superset (+0 -39 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- superset/async_events/async_query_manager.py:269:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/cli/main.py:55:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/commands/dataset/importers/v1/utils.py:212:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:529:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:562:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:566:35: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:568:37: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/cockroachdb.py:36:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/databend.py:326:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/druid.py:116:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/duckdb.py:229:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/dynamodb.py:64:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/sqlite.py:120:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/core.py:633:21: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1164:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1197:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1201:35: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1203:37: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1833:28: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/sql/parse.py:365:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/sql_parse.py:472:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/core.py:377:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/core.py:412:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:126:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:157:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:94:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:102:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:117:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:140:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:73:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:81:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:89:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:97:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:81:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:83:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:84:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/viz.py:1596:59: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/viz.py:970:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- tests/integration_tests/base_tests.py:193:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
UP038	39	0	39	0	0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -39 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/superset (+0 -39 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- superset/async_events/async_query_manager.py:269:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/cli/main.py:55:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/commands/dataset/importers/v1/utils.py:212:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:529:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:562:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:566:35: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/connectors/sqla/models.py:568:37: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/cockroachdb.py:36:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/databend.py:326:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/druid.py:116:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/duckdb.py:229:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/dynamodb.py:64:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/db_engine_specs/sqlite.py:120:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/core.py:633:21: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1164:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1197:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1201:35: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1203:37: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/models/helpers.py:1833:28: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/sql/parse.py:365:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/sql_parse.py:472:16: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/core.py:377:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/core.py:412:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:126:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:157:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/json.py:94:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:102:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:117:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:140:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:73:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:81:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:89:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/mock_data.py:97:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:81:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:83:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/utils/pandas_postprocessing/boxplot.py:84:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/viz.py:1596:59: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- superset/viz.py:970:17: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
- tests/integration_tests/base_tests.py:193:20: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
UP038	39	0	39	0	0

## Summary This PR deprecates UP038. Using PEP 604 syntax in `isinstance` and `issubclass` calls isn't a recommended pattern (or community agreed best practice) and it negatively impacts performance. Resolves #7871 ## Test Plan I tested that selecting `UP038` results in a warning in no-preview mode and an error in preview mode

* main: (53 commits) [syntax-errors] Tuple unpacking in `for` statement iterator clause before Python 3.9 (#16558) Ruff v0.10 Release (#16708) Add new `noqa` specification to the docs (#16703) describe requires-python fallback in docs (#16704) [red-knot] handle cycles in MRO/bases resolution (#16693) [red-knot] Auto generate statement nodes (#16645) [`pylint`] Better inference for `str.strip` (`PLE310`) (#16671) [`pylint`] Improve `repeated-equality-comparison` fix to use a `set` when all elements are hashable (`PLR1714`) (#16685) [`pylint`/`pep8-naming`] Check `__new__` argument name in `bad-staticmethod-argument` and not `invalid-first-argument-name-for-class-method` (`PLW0211`/`N804`) (#16676) [`flake8-pyi`] Stabilize fix for `unused-private-type-var` (`PYI018`) (#16682) [`flake8-bandit`] Deprecate `suspicious-xmle-tree-usage` (`S320`) (#16680) [`flake8-simplify`] Avoid double negation in fixes (`SIM103`) (#16684) [`pyupgrade`]: Improve diagnostic range for `redundant-open-mode` (`UP015`) (#16672) Consider all `TYPE_CHECKING` symbols for type-checking blocks (#16669) [`pep8-naming`]: Ignore methods decorated with `@typing.override` (`invalid-argument-name`) (#16667) Stabilize FURB169 preview behavior (#16666) [`pylint`] Detect invalid default value type for `os.environ.get` (`PLW1508`) (#16674) [`flake8-pytest-style`] Allow for loops with empty bodies (`PT012`, `PT031`) (#16678) [`pyupgrade`]: Deprecate `non-pep604-isinstance` (`UP038`) (#16681) [`flake8-type-checking`] Stabilize `runtime-cast-value` (`TC006`) (#16637) ...

astral-sh/ruff#16681

MichaReiser requested a review from AlexWaygood March 12, 2025 15:42

MichaReiser added rule Implementing or modifying a lint rule breaking Breaking API change labels Mar 12, 2025

MichaReiser mentioned this pull request Mar 12, 2025

UP038 rewrites code to make it slower and more verbose #7871

Closed

MichaReiser added this to the v0.10 milestone Mar 12, 2025

[pyupgrade]: Deprecate non-pep604-isinstance (UP038)

9511be4

MichaReiser force-pushed the micha/deprecate-up038 branch from a6217f2 to 9511be4 Compare March 12, 2025 15:51

MichaReiser requested a review from ntBre March 12, 2025 16:58

ntBre approved these changes Mar 12, 2025

View reviewed changes

MichaReiser mentioned this pull request Mar 13, 2025

Ruff 0.10 #16600

Merged

2 tasks

MichaReiser merged commit 2f2bcbb into micha/ruff-0.10 Mar 13, 2025
20 of 21 checks passed

MichaReiser deleted the micha/deprecate-up038 branch March 13, 2025 07:42

JulienGrv mentioned this pull request Mar 31, 2025

Feature/add type safety for mdf v4 danielhrisca/asammdf#1183

Merged

3 tasks

VeckoTheGecko mentioned this pull request May 7, 2025

UP038 documentation outdated wrt. fix safety #13051

Open

bdraco added a commit to esphome/esphome that referenced this pull request Jun 8, 2025

Disable ruff rule UP038

e54027e

astral-sh/ruff#16681

bdraco mentioned this pull request Jun 8, 2025

Disable ruff rule UP038 esphome/esphome#9029

Merged

14 tasks

MeGaGiGaGon mentioned this pull request Jun 19, 2025

Document fix safety #15584

Open

71 tasks

Julfried mentioned this pull request Oct 16, 2025

Remove deprecated Ruff rule UP038 from configuration voidsy-gmbh/pyThermoNDT#227

Merged

bdraco mentioned this pull request Nov 1, 2025

[ruff] Remove deprecated UP038 rule from ignore list esphome/esphome#11646

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[`pyupgrade`]: Deprecate `non-pep604-isinstance` (`UP038`)#16681

[`pyupgrade`]: Deprecate `non-pep604-isinstance` (`UP038`)#16681
MichaReiser merged 1 commit intomicha/ruff-0.10from
micha/deprecate-up038

MichaReiser commented Mar 12, 2025

Uh oh!

codspeed-hq bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

MichaReiser commented Mar 12, 2025

Summary

Test Plan

Uh oh!

codspeed-hq bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #16681 will degrade performances by 4.61%

Summary

Benchmarks breakdown

Uh oh!

github-actions bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Mar 12, 2025 •

edited

Loading

github-actions bot commented Mar 12, 2025 •

edited

Loading

`ruff-ecosystem` results