[red-knot] Callable member lookup, meta type impl#16618
Merged
dhruvmanila merged 2 commits intomainfrom Mar 12, 2025
Merged
Conversation
dhruvmanila
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
19 tasks
Contributor
|
sharkdp
approved these changes
Mar 11, 2025
Contributor
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Thank you for working on this. I think two minor things need to be changed before merging this.
dhruvmanila
force-pushed
the
dhruv/callable-member-lookup
branch
from
e0862d5 to
9aec57c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #16493 that implements member lookup for the general callable type.
Based on the discussion around member lookup here and
.to_meta_type()here.Test Plan
Add a new test cases.