Add new rule RUF059: Unused unpacked assignment#16449
Merged
MichaReiser merged 4 commits intoastral-sh:mainfrom Mar 3, 2025
Merged
Add new rule RUF059: Unused unpacked assignment#16449MichaReiser merged 4 commits intoastral-sh:mainfrom
MichaReiser merged 4 commits intoastral-sh:mainfrom
Conversation
Split from F841 following discussion in astral-sh#8884. Fixes astral-sh#8884.
JelleZijlstra
commented
Mar 1, 2025
| Rule::UnusedPrivateTypedDict, | ||
| Rule::UnusedPrivateTypeVar, | ||
| Rule::UnusedStaticMethodArgument, | ||
| Rule::UnusedUnpackedVariable, |
Contributor
Author
There was a problem hiding this comment.
feedback/rant: took me forever to figure out that missing this line was why my tests weren't producing any lints. It makes sense in retrospect and I don't have a better idea for how to do it, but it was a bit frustrating.
Member
There was a problem hiding this comment.
Sorry for that. Yeah, not sure what a good short-term fix for this is. My plan for Red Knot is to remove those manual checks entirely and instead have a more "formal" rule API that allows pre-computing in which phase a rule must run. This will hopefully help prevent such surprises
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| F841 | 1091 | 0 | 1091 | 0 | 0 |
| RUF059 | 831 | 831 | 0 | 0 | 0 |
| PLR0914 | 2 | 1 | 1 | 0 | 0 |
| DOC201 | 2 | 1 | 1 | 0 | 0 |
MichaReiser
added
preview
MichaReiser
approved these changes
Mar 3, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks for pushing this over the line. I'll make a few small nit improvements but this looks good.
Comment on lines
19
to
21
| /// Under [preview mode](https://docs.astral.sh/ruff/preview), this rule also | ||
| /// triggers on unused unpacked assignments (for example, `x, y = foo()`). | ||
| /// |
Member
There was a problem hiding this comment.
Suggested change
| /// Under [preview mode](https://docs.astral.sh/ruff/preview), this rule also | |
| /// triggers on unused unpacked assignments (for example, `x, y = foo()`). | |
| /// |
| Rule::UnusedPrivateTypedDict, | ||
| Rule::UnusedPrivateTypeVar, | ||
| Rule::UnusedStaticMethodArgument, | ||
| Rule::UnusedUnpackedVariable, |
Member
There was a problem hiding this comment.
Sorry for that. Yeah, not sure what a good short-term fix for this is. My plan for Red Knot is to remove those manual checks entirely and instead have a more "formal" rule API that allows pre-computing in which phase a rule must run. This will hopefully help prevent such surprises
MichaReiser
reviewed
Mar 3, 2025
Comment on lines
86
to
100
| for (name, binding) in scope | ||
| .bindings() | ||
| .map(|(name, binding_id)| (name, checker.semantic().binding(binding_id))) | ||
| .filter_map(|(name, binding)| { | ||
| if checker.settings.preview.is_enabled() | ||
| && binding.is_unpacked_assignment() | ||
| && binding.is_unused() | ||
| && !binding.is_nonlocal() | ||
| && !binding.is_global() | ||
| && !checker.settings.dummy_variable_rgx.is_match(name) | ||
| { | ||
| return Some((name, binding)); | ||
| } | ||
|
|
||
| None |
Member
There was a problem hiding this comment.
It's a bit unfortunate that this repeats the entire check from F841 with only the unpack assignment being different. Let me see if we can make this more obvious
Contributor
Author
|
Thanks for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from F841 following discussion in #8884.
Fixes #8884.
Summary
Add a new rule for unused assignments in tuples. Remove similar behavior from F841.
Test Plan
Adapt F841 tests and move them over to the new rule.