[syntax-errors] Type parameter defaults before Python 3.13#16447
Merged
Conversation
Contributor
|
Summary -- Detects the presence of a [PEP 696] type parameter default before Python 3.13. Test Plan -- New inline parser tests for type aliases, generic functions and generic classes. [PEP 696]: https://peps.python.org/pep-0696/#grammar-changes
ntBre
force-pushed
the
brent/syn-type-param-default
branch
from
e551aa2 to
f79f77c
Compare
dhruvmanila
approved these changes
Mar 3, 2025
crates/ruff_python_parser/tests/snapshots/invalid_syntax@type_param_default_py312.py.snap
Show resolved
Hide resolved
crates/ruff_python_parser/tests/snapshots/invalid_syntax@type_param_default_py312.py.snap
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Mar 3, 2025
Contributor
Author
|
Thanks! I restricted the diagnostic range to the |
dhruvmanila
reviewed
Mar 4, 2025
dhruvmanila
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detects the presence of a PEP 696 type parameter default before Python 3.13.
Test Plan
New inline parser tests for type aliases, generic functions and generic classes.