Fix missing serde feature for red_knot_python_semantic#16169
Merged
MichaReiser merged 1 commit intomainfrom Feb 14, 2025
Merged
Fix missing serde feature for red_knot_python_semantic#16169MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
requested review from
AlexWaygood,
carljm and
sharkdp
as code owners
Member
Author
|
Come on, build faster :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
cargo test -p red_knot_python_semanticfailed because of a missing serde feature. This PR enables theruff_python_ast'sserdeif the crate'sserde` feature is enabledFollow up to #16147
Test Plan
cargo test -p red_knot_python_semanticcompiles again