[pylint] Do not offer fix for raw strings (PLE251)#16132
Merged
MichaReiser merged 3 commits intoastral-sh:mainfrom Feb 13, 2025
Merged
[pylint] Do not offer fix for raw strings (PLE251)#16132MichaReiser merged 3 commits intoastral-sh:mainfrom
pylint] Do not offer fix for raw strings (PLE251)#16132MichaReiser merged 3 commits intoastral-sh:mainfrom
Conversation
InSyncWithFoo
requested review from
MichaReiser and
dhruvmanila
as code owners
Contributor
|
MichaReiser
added
rule
dhruvmanila
reviewed
Feb 13, 2025
crates/ruff_linter/src/rules/pylint/rules/invalid_string_characters.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Feb 13, 2025
dhruvmanila
reviewed
Feb 13, 2025
dhruvmanila
added a commit
that referenced
this pull request
Feb 24, 2025
## Summary This is mainly on me for not noticing this during the last release but I noticed in the last changelog that there's only 1 bug fix which didn't seem correct as I saw multiple of them so I looked at a couple of PRs that are in "Rule changes" section and the PRs that were marked with the `bug` label was categorized there because 1. It _also_ had other labels like `rule` and `fixes` (#16080, #16110, #16219, etc.) 2. Some PRs didn't have the `bug` label (but the issue as marked as `bug`) but _only_ labels like "fixes" (#16011, #16132, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #13294, follow-up to #13882.
At #13882, it was concluded that a fix should not be offered for raw strings. This change implements that. The five rules in question are now no longer always fixable.
Test Plan
cargo nextest runandcargo insta test.