Skip to content

Comments

[airflow] Add external_task.{ExternalTaskMarker, ExternalTaskSensor} for AIR302#16014

Merged
dhruvmanila merged 1 commit intoastral-sh:mainfrom
astronomer:AIR302-refactor
Feb 7, 2025
Merged

[airflow] Add external_task.{ExternalTaskMarker, ExternalTaskSensor} for AIR302#16014
dhruvmanila merged 1 commit intoastral-sh:mainfrom
astronomer:AIR302-refactor

Conversation

@Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Feb 7, 2025

Summary

Apply suggestions similar to #15922 (comment)

Test Plan

a test fixture has been updated

@Lee-W Lee-W changed the title refactor(AIR302): group similiar conditions [airflow] refactor: group multiple statement into single statement with or (AIR302) Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Feb 7, 2025
@Lee-W Lee-W changed the title [airflow] refactor: group multiple statement into single statement with or (AIR302) [airflow] include "ExternalTaskMarker" and "ExternalTaskSensor" in the "external_task" module checking (AIR302) Feb 7, 2025
@dhruvmanila dhruvmanila changed the title [airflow] include "ExternalTaskMarker" and "ExternalTaskSensor" in the "external_task" module checking (AIR302) [airflow] Add external_task.{ExternalTaskMarker, ExternalTaskSensor} for AIR302 Feb 7, 2025
@dhruvmanila dhruvmanila merged commit 618bfaf into astral-sh:main Feb 7, 2025
21 checks passed
dhruvmanila pushed a commit that referenced this pull request Mar 18, 2025
…IR302` (#16647)

## Summary

Similar to #16014. PR on Airflow
side: apache/airflow#47639

## Test Plan

A test fixture has been updated
@pbhuss
Copy link

pbhuss commented Mar 31, 2025

This looks like a bug:

AIR302 `airflow.sensors.external_task.ExternalTaskSensor` is removed in Airflow 3.0
[...]
= help: Use `airflow.sensors.external_task.ExternalTaskSensor` instead

It's suggesting replacing with itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants