[flake8-pyi] Add autofix for unused-private-type-var (PYI018)#15999
Merged
AlexWaygood merged 4 commits intoastral-sh:mainfrom Feb 6, 2025
Merged
[flake8-pyi] Add autofix for unused-private-type-var (PYI018)#15999AlexWaygood merged 4 commits intoastral-sh:mainfrom
AlexWaygood merged 4 commits intoastral-sh:mainfrom
Conversation
AlexWaygood
reviewed
Feb 6, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, this looks great!
crates/ruff_linter/src/rules/flake8_pyi/rules/unused_private_type_definition.rs
Outdated
Show resolved
Hide resolved
Contributor
|
…ype_definition.rs Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Feb 6, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you! I'll push a few small fixups and then land 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15940
Summary
This pull request adds an autofix for the
flake8-pyirule PYI018 (Unused private type variable). Currently, Ruff detects and reports unused private type variables, but it doesn't offer a way to automatically remove them. This change addresses this by providing an autofix that deletes the unused type variable definition.