[flake8-pyi] Make PEP-695 functions with multiple type parameters fixable by PYI019 again#15938
Merged
AlexWaygood merged 2 commits intomainfrom Feb 4, 2025
Merged
[flake8-pyi] Make PEP-695 functions with multiple type parameters fixable by PYI019 again#15938AlexWaygood merged 2 commits intomainfrom
flake8-pyi] Make PEP-695 functions with multiple type parameters fixable by PYI019 again#15938AlexWaygood merged 2 commits intomainfrom
Conversation
AlexWaygood
added
bug
AlexWaygood
force-pushed
the
alex/pyi019-bug
branch
from
c8b9e5a to
83c2bee
Compare
Contributor
|
dcreager
added a commit
that referenced
this pull request
Feb 4, 2025
* main: (66 commits) [red-knot] Use ternary decision diagrams (TDDs) for visibility constraints (#15861) [`pyupgrade`] Rename private type parameters in PEP 695 generics (`UP049`) (#15862) Simplify the `StringFlags` trait (#15944) [`flake8-pyi`] Make `PYI019` autofixable for `.py` files in preview mode as well as stubs (#15889) Docs (`linter.md`): clarify that Python files are always searched for in subdirectories (#15882) [`flake8-pyi`] Make PEP-695 functions with multiple type parameters fixable by PYI019 again (#15938) [red-knot] Use unambiguous invalid-syntax-construct for suppression comment test (#15933) Make `Binding::range()` point to the range of a type parameter's name, not the full type parameter (#15935) Update black deviations (#15928) [red-knot] MDTest: Fix line numbers in error messages (#15932) Preserve triple quotes and prefixes for strings (#15818) [red-knot] Hand-written MDTest parser (#15926) [`pylint`] Fix missing parens in unsafe fix for `unnecessary-dunder-call` (`PLC2801`) (#15762) nit: docs for ignore & select (#15883) [airflow] `BashOperator` has been moved to `airflow.providers.standard.operators.bash.BashOperator` (AIR302) (#15922) [`flake8-logging`] `.exception()` and `exc_info=` outside exception handlers (`LOG004`, `LOG014`) (#15799) [red-knot] Enforce specifying paths for mdtest code blocks in a separate preceding line (#15890) [red-knot] Internal refactoring of visibility constraints API (#15913) [red-knot] Implicit instance attributes (#15811) [`flake8-comprehensions`] Handle extraneous parentheses around list comprehension (`C403`) (#15877) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I realised immediately after landing #15935 that the change introduced a small bug in PYI019, which meant that functions with multiple type parameters would no longer be autofixed if one of the type parameters had a bound or constraint. The bug slipped through in #15935 because we didn't have any test coverage for this specific edge case (which shows the risk of that kind of change!).
This PR fixes the new bug and adds test coverage for the edge case. I'm adding the "internal" label: this shouldn't be included in the changelog, because it's a new bug that hasn't been included in any release of Ruff.
Test Plan
cargo test -p ruff_linter --lib