[red-knot] Add missing imports in mdtests#15869
Merged
dhruvmanila merged 2 commits intomainfrom Feb 3, 2025
Merged
Conversation
dhruvmanila
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
dhruvmanila
commented
Feb 1, 2025
dhruvmanila
force-pushed
the
dhruv/add-missing-imports
branch
from
762e315 to
6a2f1a8
Compare
AlexWaygood
approved these changes
Feb 1, 2025
crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md
Outdated
Show resolved
Hide resolved
sharkdp
approved these changes
Feb 3, 2025
MichaReiser
approved these changes
Feb 3, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks for taking the time to split this change into its own PR!
Co-authored-by: Alex Waygood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #15848, this PR adds the imports explicitly as we'll now flag these symbols as undefined.