[refurb] Mark fix as unsafe if there are comments (FURB171)#15832
Merged
dylwil3 merged 1 commit intoastral-sh:mainfrom Jan 30, 2025
Merged
[refurb] Mark fix as unsafe if there are comments (FURB171)#15832dylwil3 merged 1 commit intoastral-sh:mainfrom
refurb] Mark fix as unsafe if there are comments (FURB171)#15832dylwil3 merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
Author
|
This could be made a little better by not checking for comments within the element's range (they are not removed). Is that desired? |
Contributor
|
dylwil3
added
fixes
dylwil3
approved these changes
Jan 30, 2025
Collaborator
dylwil3
left a comment
dylwil3
left a comment
There was a problem hiding this comment.
LGTM! I don't think we need to worry about the more refined comments intersection check. Thank you!
dcreager
added a commit
that referenced
this pull request
Jan 31, 2025
* main: [`flake8-pyi`] Fix several correctness issues with `custom-type-var-return-type` (`PYI019`) (#15851) [`pyupgrade`] Reuse replacement logic from `UP046` and `UP047` (`UP040`) (#15840) [`refurb`] Avoid `None | None` as well as better detection and fix (`FURB168`) (#15779) Remove non-existing `lint.extendIgnore` editor setting (#15844) [`refurb`] Mark fix as unsafe if there are comments (`FURB171`) (#15832) [`flake8-comprehensions`] Skip when `TypeError` present from too many (kw)args for `C410`,`C411`, and `C418` (#15838) [`pyflakes`] Visit forward annotations in `TypeAliasType` as types (`F401`) (#15829)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #10063 and follow-up to #15521.
The fix is now marked as unsafe if there are any comments within its range. Tests are adapted from that of #15521.
Test Plan
cargo nextest runandcargo insta test.