[red-knot] Do not use explicit knot_extensions.Unknown declaration#15787
Merged
[red-knot] Do not use explicit knot_extensions.Unknown declaration#15787
knot_extensions.Unknown declaration#15787Conversation
sharkdp
requested review from
AlexWaygood,
MichaReiser and
carljm
as code owners
sharkdp
commented
Jan 28, 2025
|
|
||
| ```bash | ||
| uv -q run crates/red_knot_python_semantic/mdtest.py | ||
| uv run crates/red_knot_python_semantic/mdtest.py |
Contributor
Author
There was a problem hiding this comment.
Drive-by fix, -q is not needed anymore to silence the "Reading inline script metadata from …" message since astral-sh/uv#10588
carljm
approved these changes
Jan 28, 2025
dcreager
added a commit
that referenced
this pull request
Jan 29, 2025
* main: [red-knot] Extend instance-attribute tests (#15808) Fix formatter warning message for `flake8-quotes` option (#15788) [`flake8-bugbear`] Exempt `NewType` calls where the original type is immutable (`B008`) (#15765) Add missing config docstrings (#15803) [`refurb`] Do not emit diagnostic when loop variables are used outside loop body (`FURB122`) (#15757) [`ruff`] Check for shadowed `map` before suggesting fix (`RUF058`) (#15790) [red-knot] Do not use explicit `knot_extensions.Unknown` declaration (#15787) Preserve quotes in generated byte strings (#15778) [minor] Simplify some `ExprStringLiteral` creation logic (#15775) Preserve quote style in generated code (#15726) Rename internal helper functions (#15771) [`airflow`] Extend airflow context parameter check for `BaseOperator.execute` (`AIR302`) (#15713) Implement tab autocomplete for `ruff config` (#15603)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not use an explict
knot_extensions.Unknowndeclaration, as per this comment. Instead, use an undefined name to achieve the same effect.