[ty] Ensure that bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy#15784
Closed
AlexWaygood wants to merge 5 commits intomainfrom
Closed
[ty] Ensure that bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy#15784AlexWaygood wants to merge 5 commits intomainfrom
bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy#15784AlexWaygood wants to merge 5 commits intomainfrom
Conversation
AlexWaygood
force-pushed
the
alex/truthy-unions-7
branch
from
e344a4f to
1a94b3f
Compare
AlexWaygood
force-pushed
the
alex/truthy-unions-7
branch
2 times, most recently
from
d7082e4 to
e4a7142
Compare
AlexWaygood
force-pushed
the
alex/truthy-unions-7
branch
from
e4a7142 to
91784bb
Compare
Member
|
@AlexWaygood is this PR (and the other once mentioned in the summary) still something you plan to work on or can we close the PRs? |
AlexWaygood
changed the title
bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsybool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy
Member
Author
|
very merge-conflicted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is yet another alternative to #15738 and #15773.
I'll writeup a fuller PR summary once I've seen the benchmark results...
Test Plan