better error messages while loading configuration extends#15658
Merged
MichaReiser merged 6 commits intoastral-sh:mainfrom Feb 17, 2025
Merged
better error messages while loading configuration extends#15658MichaReiser merged 6 commits intoastral-sh:mainfrom
extends#15658MichaReiser merged 6 commits intoastral-sh:mainfrom
Conversation
Contributor
|
purajit
force-pushed
the
20250121-inheritance-failure-err-msg
branch
from
b8c2fbe to
730bae4
Compare
MichaReiser
reviewed
Jan 22, 2025
MichaReiser
reviewed
Jan 22, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Nice, this is a great improvement. I've some suggestions on how we can improve the message further. It would probably also be good to add a CLI test for it, similar to what we have here
purajit
force-pushed
the
20250121-inheritance-failure-err-msg
branch
3 times, most recently
from
0531622 to
93d45b2
Compare
purajit
changed the title
extends
MichaReiser
force-pushed
the
20250121-inheritance-failure-err-msg
branch
from
06beb84 to
bc67b84
Compare
dcreager
added a commit
that referenced
this pull request
Feb 18, 2025
* main: (60 commits) [`refurb`] Manual timezone monkeypatching (`FURB162`) (#16113) [`pyupgrade`] Do not upgrade functional TypedDicts with private field names to the class-based syntax (`UP013`) (#16219) Improve docs for PYI019 (#16229) Refactor `CallOutcome` to `Result` (#16161) Fix minor punctuation errors (#16228) Include document specific debug info (#16215) Update server to return the debug info as string (#16214) [`airflow`] Group `ImportPathMoved` and `ProviderName` to avoid misusing (`AIR303`) (#16157) Fix unstable formatting of trailing end-of-line comments of parenthesized attribute values (#16187) Ignore source code actions for a notebook cell (#16154) Add FAQ entry for `source.*` code actions in Notebook (#16212) red-knot: move symbol lookups in `symbol.rs` (#16152) better error messages while loading configuration `extend`s (#15658) Format `index.css` (#16207) Improve API exposed on `ExprStringLiteral` nodes (#16192) Update Rust crate tempfile to v3.17.0 (#16202) Update cloudflare/wrangler-action action to v3.14.0 (#16203) Update NPM Development dependencies (#16199) Update Rust crate smallvec to v1.14.0 (#16201) Update Rust crate codspeed-criterion-compat to v2.8.0 (#16200) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves error messages during errors caused while extending a configuration using
extend.In the case of circular dependencies, it actually fixes the error too!
Old error messages:
Now: