Skip to content

Comments

Bring back issue template#15651

Merged
MichaReiser merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:issue-template
Jan 22, 2025
Merged

Bring back issue template#15651
MichaReiser merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:issue-template

Conversation

@InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Jan 21, 2025

Summary

Resolves #15641.

Test Plan

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Jan 21, 2025

The description field is not shown to the user but mandatory nevertheless.

@MichaReiser
Copy link
Member

MichaReiser commented Jan 21, 2025

Nice, thank you. @zanieb this looks good to me, wdyt?

@InSyncWithFoo just to confirm. Clicking on "new issue" now goes directly to the editor without showing a selector?

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Jan 21, 2025
@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Jan 21, 2025

Clicking on "new issue" now goes directly to the editor without showing a selector?

Yes, that's correct.

actionlint seems to be complain about something, just like last time. I don't know what that is (line endings?).

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 21, 2025

actionlint seems to be complain about something, just like last time. I don't know what that is (line endings?).

(it's actually prettier that was complaining, not actionlint. I don't know what it was complaining about, but line endings seems plausible.)

@zanieb
Copy link
Member

zanieb commented Jan 21, 2025

Should we align these with the uv templates? or just restore this first?

@zanieb
Copy link
Member

zanieb commented Jan 21, 2025

See

@MichaReiser
Copy link
Member

MichaReiser commented Jan 21, 2025

We should restore them first. Adopting something similar to uv requires some more effort

MichaReiser
MichaReiser approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks for updating the template. Let's see how it goes. We can iterate on the template as we see fit.

@MichaReiser MichaReiser merged commit 6fe404a into astral-sh:main Jan 22, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the issue-template branch January 22, 2025 12:08
@zanieb zanieb mentioned this pull request Feb 17, 2025
Merged
dhruvmanila added a commit that referenced this pull request Feb 25, 2025
@zanieb @dhruvmanila
Add issue templates (#16213)
1be0dc6 
Follows #15651

Preview: https://github.com/dhruvmanila/ruff-issue-templates/issues

GitHub made the interface for single-template repositories worse. While
they might fix it, it encouragement to just do this work. They still
haven't fixed the teeny tiny emojis which makes me think this won't be
fixed quickly.

Before:

<img width="1267" alt="Screenshot 2025-02-17 at 8 26 08 AM"
src="https://github.com/user-attachments/assets/e69ef630-4296-470e-ab4d-a22d55785444"
/>

After:

<img width="1688" alt="Screenshot 2025-02-24 at 3 05 35 PM"
src="https://github.com/user-attachments/assets/61033666-1fe5-421b-a69c-1aa79bcc85b5"
/>

---------

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bring back issue template

4 participants

@InSyncWithFoo @MichaReiser @AlexWaygood @zanieb