Skip to content

Comments

Remove test rules from JSON schema#15627

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/test-rules
Jan 24, 2025
Merged

Remove test rules from JSON schema#15627
dhruvmanila merged 1 commit intomainfrom
dhruv/test-rules

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jan 21, 2025 •
edited
Loading

Closes: #15707

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jan 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member

MichaReiser commented Jan 21, 2025

I'm not sure this is the right fix but I can see how any other fix is annoying.

The reason why I don't think we should enable testing in ruff_dev is because users can't select the testing rules and, therefore, they shouldn't be in the json schema. If they currently are, then that's a bug and we should remove them.

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Jan 21, 2025

I'm not sure this is the right fix but I can see how any other fix is annoying.

The reason why I don't think we should enable testing in ruff_dev is because users can't select the testing rules and, therefore, they shouldn't be in the json schema. If they currently are, then that's a bug and we should remove them.

Oh, right. That makes more sense. Thanks for catching that, I've updated the PR.

@dhruvmanila dhruvmanila changed the title Use ruff_linter with the "test-rules" features in ruff_dev Remove test rules from JSON schema Jan 21, 2025
@dhruvmanila dhruvmanila mentioned this pull request Jan 24, 2025
Closed
@dhruvmanila dhruvmanila merged commit 9384ba4 into main Jan 24, 2025
21 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/test-rules branch January 24, 2025 04:48
InSyncWithFoo added a commit to InSyncWithFoo/ruff that referenced this pull request Jan 24, 2025
@InSyncWithFoo
Revert astral-sh#15627
aeb4fd4
@InSyncWithFoo InSyncWithFoo mentioned this pull request Jan 24, 2025
Closed
dcreager added a commit that referenced this pull request Jan 24, 2025
@dcreager
Merge branch 'main' into dcreager/terminal-visibility
b9f91fb 
* main:
  Add `check` command (#15692)
  [red-knot] Use itertools to clean up `SymbolState::merge` (#15702)
  [red-knot] Add `--ignore`, `--warn`, and `--error` CLI arguments (#15689)
  Use `uv init --lib` in tutorial (#15718)
  [red-knot] Use `Unknown | T_inferred` for undeclared public symbols (#15674)
  [`ruff`] Parenthesize fix when argument spans multiple lines for `unnecessary-round` (`RUF057`) (#15703)
  [red-knot] Rename `TestDbBuilder::typeshed` to `.custom_typeshed` (#15712)
  Honor banned top level imports by TID253 in PLC0415.  (#15628)
  Apply `AIR302`-context check only in `@task` function (#15711)
  [`airflow`] Update `AIR302` to check for deprecated context keys (#15144)
  Remove test rules from JSON schema (#15627)
  Add two missing commits to changelog (#15701)
  Fix grep for version number in docker build (#15699)
  Bump version to 0.9.3 (#15698)
  Preserve raw string prefix and escapes (#15694)
  [`flake8-pytest-style`] Rewrite references to `.exception` (`PT027`) (#15680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_generate_json_schema failing as of 0.9.2

2 participants

@dhruvmanila @MichaReiser