[pyupgrade] Functional enums (UP048)#15625
Closed
InSyncWithFoo wants to merge 3 commits intoastral-sh:mainfrom
Closed
[pyupgrade] Functional enums (UP048)#15625InSyncWithFoo wants to merge 3 commits intoastral-sh:mainfrom
pyupgrade] Functional enums (UP048)#15625InSyncWithFoo wants to merge 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| UP048 | 3 | 3 | 0 | 0 | 0 |
Member
|
I'm not sure UP is a good fit. Using class—or functional-based enums seems more a matter of taste than whether one is considered better (because it was intentionally designed for it) than the other. I think this is also visible in the ecosystem checks, where the function-based notation is more concise than the class one. Overall, I think we should hold off with this rule. It seems too opinionated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #12417.
Test Plan
cargo nextest runandcargo insta test.