Conversation
cec1f57 to
7b159ab
Compare
Contributor
|
MichaReiser
reviewed
Jan 20, 2025
fb64180 to
2bafb68
Compare
MichaReiser
approved these changes
Jan 20, 2025
2bafb68 to
bd9d274
Compare
MichaReiser
reviewed
Jan 20, 2025
bd9d274 to
9230407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
General rules:
_tysuffix of all functions to_type._type_and_qualifierssuffixes seem too long, so we ignore the existence of qualifiers and still speak of "types"_typesuffix if they return eitherType,Option<Type>, orTypeAndQualifiersFree functions:
binding_ty=>binding_typedeclaration_ty=>declaration_typedefinition_expression_ty=>definition_expression_typeMethods:
CallDunderResult::return_ty=>return_typeNotCallableError::return_ty=>return_typeNotCallableError::called_ty=>called_typeTypeAndQualifiers::inner_ty=>inner_typeTypeAliasType::value_ty=>value_typeTypeInference::expression_ty=>expression_typeTypeInference::try_expression_ty=>try_expression_typeTypeInference::binding_ty=>binding_typeTypeInference::declaration_ty=>declaration_typeTypeInferenceBuilder::expression_ty=>expression_typeTypeInferenceBuilder::file_expression_ty=>file_expression_typeTypeInferenceBuilder::module_ty_from_name=>module_type_from_nameClassBase::try_from_ty=>try_from_typeParameter::annotated_ty=>annotated_typeParameter::default_ty=>default_typeCallOutcome::return_ty=>return_typeCallOutcome::return_ty_result=>return_type_resultCallBinding::from_return_ty=>from_return_typeCallBinding::set_return_ty=>set_return_typeCallBinding::return_ty=>return_typeCallBinding::parameter_tys=>parameter_typesCallBinding::one_parameter_ty=>one_parameter_typeCallBinding::two_parameter_tys=>two_parameter_typesUnpacker::tuple_ty_elements=>tuple_type_elementsStringPartsCollector::ty=>string_typeTraits
HasTy=>HasTypeHasTy::ty=>inferred_typeTest functions:
assert_public_ty=>assert_public_typeassert_scope_ty=>assert_scope_typecloses #15569
Test Plan
—