Skip to content

Comments

[red-knot] Two gradual equivalent fully static types are also equivalent#15579

Merged
AlexWaygood merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:rk-pt-is-gradual-equivalent-to
Jan 19, 2025
Merged

[red-knot] Two gradual equivalent fully static types are also equivalent#15579
AlexWaygood merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:rk-pt-is-gradual-equivalent-to

Conversation

@InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Jan 19, 2025

Summary

Follow-up to #15563, related to this comment there.

Test Plan

Type property tests.

@InSyncWithFoo InSyncWithFoo mentioned this pull request Jan 19, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood added testing Related to testing Ruff itself ty Multi-file analysis & type inference labels Jan 19, 2025
AlexWaygood
AlexWaygood reviewed Jan 19, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you say a little bit about why you added this test to the flaky submodule in this file rather than the stable submodule? Did it ever fail when you ran the property tests locally? I stress-tested the flaky property tests by running QUICKCHECK_TESTS=2000000 cargo test --release -p red_knot_python_semantic -- --ignored types::property_tests::flaky several times locally on this branch (after merging in main), and neither the new test you're adding here nor two_equivalent_types_are_also_gradual_equivalent failed once.

That implies to me that we should be adding this test to the stable submodule in this file? And also promoting two_equivalent_types_are_also_gradual_equivalent to stable?

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Jan 19, 2025

Promoted. I thought I should remain careful "just in case".

@AlexWaygood AlexWaygood enabled auto-merge (squash) January 19, 2025 16:34
@AlexWaygood AlexWaygood merged commit 444f799 into astral-sh:main Jan 19, 2025
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-pt-is-gradual-equivalent-to branch January 19, 2025 16:37
sharkdp pushed a commit that referenced this pull request Jan 20, 2025
@InSyncWithFoo
[red-knot] Migrate is_disjoint_from unit tests to Markdown tests (#…
975d145 
…15580)

## Summary

Part of and resolves #15397, built on top of #15579.

## Test Plan

Markdown tests.
@AlexWaygood AlexWaygood mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@carljm carljm Awaiting requested review from carljm

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

@sharkdp sharkdp Awaiting requested review from sharkdp

Assignees

No one assigned

Labels

testing Related to testing Ruff itself ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@InSyncWithFoo @AlexWaygood