Skip to content

Comments

[red-knot] Inline SubclassOfType::as_instance_type_of_metaclass()#15556

Merged
AlexWaygood merged 1 commit intomainfrom
alex/inline-dubious-method
Jan 17, 2025
Merged

[red-knot] Inline SubclassOfType::as_instance_type_of_metaclass()#15556
AlexWaygood merged 1 commit intomainfrom
alex/inline-dubious-method

Conversation

@AlexWaygood
Copy link
Member

Addresses the review comment at #15547 (comment)

@AlexWaygood AlexWaygood added the ty Multi-file analysis & type inference label Jan 17, 2025
@AlexWaygood AlexWaygood enabled auto-merge (squash) January 17, 2025 18:58
@AlexWaygood AlexWaygood merged commit 4351d85 into main Jan 17, 2025
20 checks passed
@AlexWaygood AlexWaygood deleted the alex/inline-dubious-method branch January 17, 2025 19:01
@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dcreager added a commit that referenced this pull request Jan 17, 2025
* main:
  [red-knot] Inline `SubclassOfType::as_instance_type_of_metaclass()` (#15556)
  [`flake8-comprehensions`] strip parentheses around generators in `unnecessary-generator-set` (`C401`) (#15553)
  [`pylint`] Implement `redefined-slots-in-subclass` (`W0244`) (#9640)
  [`flake8-bugbear`] Do not raise error if keyword argument is present and target-python version is less or equals than 3.9 (`B903`) (#15549)
  [red-knot] `type[T]` is disjoint from `type[S]` if the metaclass of `T` is disjoint from the metaclass of `S` (#15547)
  [red-knot] Pure instance variables declared in class body (#15515)
  Update snapshots of #15507 with new annotated snipetts rendering (#15546)
  [`pylint`] Do not report methods with only one `EM101`-compatible `raise` (`PLR6301`) (#15507)
  Fix unstable f-string formatting for expressions containing a trailing comma (#15545)
  Support `knot.toml` files in project discovery (#15505)
  Add support for configuring knot in `pyproject.toml` files (#15493)
  Fix bracket spacing for single-element tuples in f-string expressions (#15537)
  [`flake8-simplify`] Do not emit diagnostics for expressions inside string type annotations (`SIM222`, `SIM223`) (#15405)
  [`flake8-pytest-style`] Do not emit diagnostics for empty `for` loops (`PT012`, `PT031`) (#15542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants