[red-knot] Simplify object out of intersections#15511
Merged
AlexWaygood merged 2 commits intomainfrom Jan 15, 2025
Merged
Conversation
Contributor
|
Contributor
|
I recently wrote this down (in an unpublished branch):
Thanks for explicitly implementing the "intersecting with |
sharkdp
reviewed
Jan 15, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_equivalent_to.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 15, 2025
carljm
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
object & intis equivalent toint,object & Unknownis equivalent toUnknown,object & ~intis equivalent to~int... I could go on ;)objectis the top type, the supertype of everything, so it is always redundant in an intersection. Eagerly simplifying it out of intersections is easy, and fixes some property-test failures in another branch of mine.Test Plan
QUICKCHECK_TESTS=200000 cargo test --release -p red_knot_python_semantic -- --ignored types::property_tests::stableuvx pre-commit run -a