[red-knot] Understand type[Unknown]#15409
Merged
carljm merged 1 commit intoastral-sh:mainfrom Jan 10, 2025
Merged
Conversation
InSyncWithFoo
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
Contributor
|
carljm
approved these changes
Jan 10, 2025
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Thank you! I was going to comment on the previous PR that this should be really easy to fix, but it also seemed like scope creep for that PR. Thanks for following up on it.
Contributor
|
I'm not sure what is going on with the fuzzer build here, but it doesn't seem at all related to this PR. |
Contributor
Author
|
@carljm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #15194.
Test Plan
Markdown tests.