Skip to content

Comments

[flake8-builtins] Disapply A005 to stub files#15350

Merged
AlexWaygood merged 1 commit intomainfrom
alex/flake8-builtins-stubs
Jan 8, 2025
Merged

[flake8-builtins] Disapply A005 to stub files#15350
AlexWaygood merged 1 commit intomainfrom
alex/flake8-builtins-stubs

Conversation

@AlexWaygood
Copy link
Member

Summary

The rule doesn't make sense for stub files; the name of a module is outside the control of the stub author. See #15293

Test Plan

cargo test -p ruff_linter --lib

@AlexWaygood AlexWaygood added the rule Implementing or modifying a lint rule label Jan 8, 2025
@AlexWaygood AlexWaygood enabled auto-merge (squash) January 8, 2025 12:59
@AlexWaygood AlexWaygood merged commit ee9a912 into main Jan 8, 2025
20 checks passed
@AlexWaygood AlexWaygood deleted the alex/flake8-builtins-stubs branch January 8, 2025 12:59
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dcreager added a commit that referenced this pull request Jan 8, 2025
* main:
  [`pylint`] Fix `unreachable` infinite loop (`PLW0101`) (#15278)
  fix invalid syntax in workflow file (#15357)
  [`pycodestyle`] Avoid false positives related to type aliases (`E252`) (#15356)
  [`flake8-builtins`] Disapply `A005` to stub files (#15350)
  Improve logging system using `logLevel`, avoid trace value (#15232)
  [`flake8-builtins`] Rename `A005` and improve its error message (#15348)
  Spruce up docs for pydoclint rules (#15325)
  [`flake8-type-checking`] Apply `TC008` more eagerly in `TYPE_CHECKING` blocks and disapply it in stubs (#15180)
  [red-knot] `knot_extensions` Python API (#15103)
  Display Union of Literals as a Literal (#14993)
  [red-knot] all types are assignable to object (#15332)
  [`ruff`] Parenthesize arguments to `int` when removing `int` would change semantics in `unnecessary-cast-to-int` (`RUF046`) (#15277)
  [`eradicate`] Correctly handle metadata blocks directly followed by normal blocks (`ERA001`) (#15330)
  Narrowing for class patterns in match statements (#15223)
  [red-knot] add call checking (#15200)
  Spruce up docs for `slice-to-remove-prefix-or-suffix` (`FURB188`) (#15328)
  [`internal`] Return statements in finally block point to end block for `unreachable` (`PLW0101`) (#15276)
  [`ruff`] Treat `)` as a regex metacharacter (`RUF043`, `RUF055`) (#15318)
  Use uv consistently throughout the documentation (#15302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants