[flake8-return] Recognize functions returning Never as non-returning (RET503)#15298
[flake8-return] Recognize functions returning Never as non-returning (RET503)#15298MichaReiser merged 2 commits intoastral-sh:mainfrom
flake8-return] Recognize functions returning Never as non-returning (RET503)#15298Conversation
|
| 376 376 | if x == 5: | ||
| 377 377 | return 5 | ||
| 378 378 | bar() | ||
| 379 |+ return None |
There was a problem hiding this comment.
Your code changes look correct, but they seem to have no effect. I'd expect that the rule wouldn't flag this specific line because there's no implicit return (it never returns). I added a ton of debug statements to is_noreturn_func and I suspect the problem is that the semantic model hasn't seen bar at the moment we try to resolve its name. My suspicious gets confirmed when changing the example to
import typing
def bar() -> typing.Never:
abort()
def foo(x: int) -> int:
if x == 5:
return 5
bar()which raises a violation before your change but now doesn't.
I suggest that you change your examples (including the existing NoReturn) to not use a nested function. We can add a dedicated test with a nested function with a doc comment explaining that this is currently not supported.
There was a problem hiding this comment.
I have changed the current tests to no longer use nested functions and have added a currently ignored test checking nested functions.
…and add explanation why it isn't supported yet
* main: Use uv consistently throughout the documentation (#15302) [red-knot] Eagerly normalize `type[]` types (#15272) [`pyupgrade`] Split `UP007` to two individual rules for `Union` and `Optional` (`UP007`, `UP045`) (#15313) [red-knot] Improve symbol-lookup tracing (#14907) [red-knot] improve type shrinking coverage in red-knot property tests (#15297) [`flake8-return`] Recognize functions returning `Never` as non-returning (`RET503`) (#15298) [`flake8-bugbear`] Implement `class-as-data-structure` (`B903`) (#9601) Avoid treating newline-separated sections as sub-sections (#15311) Remove call when removing final argument from `format` (#15309) Don't enforce `object-without-hash-method` in stubs (#15310) Don't special-case class instances in binary expression inference (#15161) Upgrade zizmor to the latest version in CI (#15300)
2 participants
Summary
This pull request makes
flake8-returnrecognize functions annotated to returntyping.Neveras non-returning.Test Plan
I have duplicated the existing tests for functions returning
NoReturn.