Revert "Add all PEP-585 names to UP006 rule"#15250
Merged
MichaReiser merged 2 commits intomainfrom Jan 4, 2025
Merged
Conversation
This reverts commit 04d5381.
MichaReiser
commented
Jan 4, 2025
|
|
||
| #[test] | ||
| fn verbose_show_failed_fix_errors() { | ||
| let mut cmd = RuffCheck::default() |
Member
Author
There was a problem hiding this comment.
@dylwil3 I had to remove those tests. I think they did their job to prove that your change was working, so I don't think we have to write new ones. If we do, we should create a dummy rule instead to avoid depending on actual rule behavior.
MichaReiser
force-pushed
the
revert-5454-more-UP006-detection
branch
from
a31d773 to
c58997d
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FA100 | 4 | 0 | 4 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -2435 violations, +0 -0 fixes in 22 projects; 33 projects unchanged)
aiven/aiven-client (+0 -409 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- aiven/client/argx.py:104:38: UP006 Use `collections.abc.Iterable` instead of `Iterable` for type annotation - aiven/client/argx.py:155:54: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:171:45: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:174:49: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:241:29: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:278:34: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:278:44: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:290:32: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - aiven/client/argx.py:300:29: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - aiven/client/argx.py:303:34: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation ... 399 additional changes omitted for project
apache/airflow (+0 -483 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/api/auth/backend/deny_all.py:34:24: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/parameters.py:87:24: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/parameters.py:90:52: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/parameters.py:90:78: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:114:6: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:161:54: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:180:53: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:199:57: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:218:54: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - airflow/api_connexion/security.py:237:6: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation ... 473 additional changes omitted for project
apache/superset (+0 -167 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- scripts/check-env.py:37:40: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/advanced_data_type/types.py:58:21: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/advanced_data_type/types.py:59:23: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/cli/test_db.py:81:12: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/cli/test_db.py:88:38: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/commands/chart/export.py:80:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/commands/dashboard/export.py:168:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/commands/database/export.py:108:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/commands/dataset/export.py:87:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - superset/commands/dataset/importers/v0.py:129:22: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation ... 157 additional changes omitted for project
bokeh/bokeh (+0 -250 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- release/action.py:27:31: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - release/action.py:27:52: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - release/action.py:35:47: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - release/build.py:144:22: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - release/credentials.py:37:22: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - release/credentials.py:40:38: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - release/pipeline.py:24:12: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - release/pipeline.py:34:31: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - release/ui.py:103:33: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - release/ui.py:24:17: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation ... 240 additional changes omitted for project
ibis-project/ibis (+0 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- ibis/common/tests/test_patterns.py:1122:13: UP006 [*] Use `collections.abc.Callable` instead of `Callable` for type annotation - ibis/common/tests/test_patterns.py:1125:10: UP006 [*] Use `collections.abc.Callable` instead of `Callable` for type annotation - ibis/common/tests/test_patterns.py:731:31: UP006 [*] Use `collections.abc.Callable` instead of `Callable` for type annotation
langchain-ai/langchain (+0 -299 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- libs/core/langchain_core/_api/beta_decorator.py:128:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/beta_decorator.py:186:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/beta_decorator.py:201:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/beta_decorator.py:30:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/beta_decorator.py:39:6: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/deprecation.py:202:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/deprecation.py:232:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/deprecation.py:252:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/deprecation.py:268:47: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - libs/core/langchain_core/_api/deprecation.py:300:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation ... 289 additional changes omitted for project
lnbits/lnbits (+0 -47 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- lnbits/app.py:342:46: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/app.py:352:47: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/core/models.py:332:30: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/core/models.py:333:31: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/core/views/auth_api.py:340:49: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/lnurl.py:24:36: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/tasks.py:143:11: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - lnbits/tasks.py:143:31: UP006 Use `collections.abc.Coroutine` instead of `Coroutine` for type annotation - lnbits/tasks.py:144:19: UP006 Use `collections.abc.Coroutine` instead of `Coroutine` for type annotation - lnbits/tasks.py:144:6: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation ... 37 additional changes omitted for project
milvus-io/pymilvus (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- _version_helper.py:32:17: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation
mlflow/mlflow (+0 -101 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- dev/clint/src/clint/linter.py:110:42: UP006 Use `collections.abc.Iterator` instead of `Iterator` for type annotation - dev/set_matrix.py:317:56: UP006 Use `collections.abc.Iterator` instead of `Iterator` for type annotation - mlflow/bedrock/_autolog.py:46:35: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/bedrock/_autolog.py:46:58: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/data/dataset_registry.py:122:48: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/data/dataset_registry.py:18:31: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/data/dataset_registry.py:63:47: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/data/dataset_registry.py:93:42: UP006 Use `collections.abc.Callable` instead of `Callable` for type annotation - mlflow/data/huggingface_dataset.py:180:37: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - mlflow/data/huggingface_dataset.py:180:52: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation ... 91 additional changes omitted for project
pypa/build (+0 -6 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- src/build/_builder.py:120:14: UP006 Use `collections.abc.Sequence` instead of `Sequence` for type annotation - src/build/_builder.py:120:68: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation - src/build/_builder.py:39:28: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation - src/build/_builder.py:60:44: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation - src/build/_builder.py:74:47: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation - src/build/_builder.py:74:69: UP006 Use `collections.abc.Mapping` instead of `Mapping` for type annotation
... Truncated remaining completed project reports due to GitHub comment length restrictions
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| UP006 | 2431 | 0 | 2431 | 0 | 0 |
| FA100 | 4 | 0 | 4 | 0 | 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5454