Show errors for attempted fixes only when passed --verbose#15237
Merged
dylwil3 merged 5 commits intoastral-sh:mainfrom Jan 3, 2025
Merged
Show errors for attempted fixes only when passed --verbose#15237dylwil3 merged 5 commits intoastral-sh:mainfrom
--verbose#15237dylwil3 merged 5 commits intoastral-sh:mainfrom
Conversation
dylwil3
added
cli
Contributor
|
dcreager
added a commit
that referenced
this pull request
Jan 3, 2025
* main: [`ruff`] Avoid reporting when `ndigits` is possibly negative (`RUF057`) (#15234) Attribute panics to the mdtests that cause them (#15241) Show errors for attempted fixes only when passed `--verbose` (#15237) [`RUF`] Add rule to detect empty literal in deque call (`RUF025`) (#15104) TD003: remove issue code length restriction (#15175) Preserve multiline implicit concatenated strings in docstring positions (#15126) [`pyflakes`] Ignore errors in `@no_type_check` string annotations (`F722`, `F821`) (#15215) style(AIR302): rename removed_airflow_plugin_extension as check_airflow_plugin_extension (#15233) [`pylint`] Re-implement `unreachable` (`PLW0101`) (#10891) refactor(AIR303): move duplicate qualified_name.to_string() to Diagnostic argument (#15220) Misc. clean up to rounding rules (#15231) Avoid syntax error when removing int over multiple lines (#15230) Migrate renovate config (#15228) Remove `Type::tuple` in favor of `TupleType::from_elements` (#15218)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default logging level for diagnostics includes logs written using the
logcrate with levelerror,warn, andinfo. An unsuccessful fix attached to a diagnostic viatry_set_fixortry_set_optional_fixwas logged at levelerror. Note that the user would see these messages even without passing--fix, and possibly also on lines withnoqacomments.This PR changes the logging level here to a
debug. We also found ad-hoc instances of error logging in the implementations of several rules, and have replaced those with either adebugor call totry_set{_optional}_fix.Closes #15229