[red-knot] add call checking by carljm · Pull Request #15200 · astral-sh/ruff

carljm · 2024-12-30T08:22:39Z

Summary

This implements checking of calls.

I ended up following Micha's original suggestion from back when the signature representation was first introduced, and flattening it to a single array of parameters. This turned out to be easier to manage, because we can represent parameters using indices into that array, and represent the bound argument types as an array of the same length.

Starred and double-starred arguments are still TODO; these won't be very useful until we have generics.

The handling of diagnostics is just hacked into return_ty_result, which was already inconsistent about whether it emitted diagnostics or not; now it's even more inconsistent. This needs to be addressed, but could be a follow-up.

The new benchmark errors here surface the need for intersection support in is_assignable_to.

Fixes #14161.

Test Plan

Added mdtests.

github-actions · 2024-12-30T08:31:32Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood

haven't finished reviewing (or reading the diff), but here's what I have so far

crates/red_knot_python_semantic/resources/mdtest/call/function.md

crates/red_knot_python_semantic/src/types/call.rs

crates/red_knot_python_semantic/src/types/call/arguments.rs

crates/red_knot_python_semantic/src/types/call/bind.rs

crates/red_knot_python_semantic/src/types/call/arguments.rs

crates/red_knot_python_semantic/src/types/call/bind.rs

crates/red_knot_python_semantic/resources/mdtest/call/function.md

carljm · 2025-01-07T07:50:51Z

Thanks for the reviews! I think I've addressed all comments so far.

crates/red_knot_python_semantic/src/types/call/arguments.rs

crates/red_knot_python_semantic/src/types/signatures.rs

crates/red_knot_python_semantic/src/types/infer.rs

crates/red_knot_python_semantic/src/types/call/bind.rs

AlexWaygood

(Still not a full review)

crates/red_knot_python_semantic/resources/mdtest/call/function.md

crates/red_knot_python_semantic/src/types/call/bind.rs

crates/red_knot_python_semantic/resources/mdtest/call/function.md

crates/red_knot_python_semantic/src/types/signatures.rs

carljm · 2025-01-07T20:30:41Z

Thanks for all the great review comments! I think I've addressed them all, planning to land if CI is green.

* main: [`pylint`] Fix `unreachable` infinite loop (`PLW0101`) (#15278) fix invalid syntax in workflow file (#15357) [`pycodestyle`] Avoid false positives related to type aliases (`E252`) (#15356) [`flake8-builtins`] Disapply `A005` to stub files (#15350) Improve logging system using `logLevel`, avoid trace value (#15232) [`flake8-builtins`] Rename `A005` and improve its error message (#15348) Spruce up docs for pydoclint rules (#15325) [`flake8-type-checking`] Apply `TC008` more eagerly in `TYPE_CHECKING` blocks and disapply it in stubs (#15180) [red-knot] `knot_extensions` Python API (#15103) Display Union of Literals as a Literal (#14993) [red-knot] all types are assignable to object (#15332) [`ruff`] Parenthesize arguments to `int` when removing `int` would change semantics in `unnecessary-cast-to-int` (`RUF046`) (#15277) [`eradicate`] Correctly handle metadata blocks directly followed by normal blocks (`ERA001`) (#15330) Narrowing for class patterns in match statements (#15223) [red-knot] add call checking (#15200) Spruce up docs for `slice-to-remove-prefix-or-suffix` (`FURB188`) (#15328) [`internal`] Return statements in finally block point to end block for `unreachable` (`PLW0101`) (#15276) [`ruff`] Treat `)` as a regex metacharacter (`RUF043`, `RUF055`) (#15318) Use uv consistently throughout the documentation (#15302)

carljm added the ty Multi-file analysis & type inference label Dec 30, 2024

carljm force-pushed the cjm/checksigs branch from 3ade548 to 7640a14 Compare December 30, 2024 08:51

AlexWaygood mentioned this pull request Jan 3, 2025

[red-knot] knot_extensions Python API #15103

Merged

7 tasks

carljm force-pushed the cjm/checksigs branch from 7640a14 to 6b3b62e Compare January 6, 2025 17:09

carljm marked this pull request as ready for review January 6, 2025 17:11

carljm requested review from AlexWaygood, MichaReiser and sharkdp as code owners January 6, 2025 17:11

AlexWaygood reviewed Jan 6, 2025

View reviewed changes

sharkdp reviewed Jan 6, 2025

View reviewed changes

crates/red_knot_python_semantic/resources/mdtest/call/function.md Show resolved Hide resolved

carljm force-pushed the cjm/checksigs branch from 6b3b62e to 0ab9848 Compare January 7, 2025 06:50

MichaReiser approved these changes Jan 7, 2025

View reviewed changes

AlexWaygood reviewed Jan 7, 2025

View reviewed changes

crates/red_knot_python_semantic/resources/mdtest/call/function.md Outdated Show resolved Hide resolved

AlexWaygood reviewed Jan 7, 2025

View reviewed changes

crates/red_knot_python_semantic/src/types/signatures.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types/signatures.rs Outdated Show resolved Hide resolved

carljm added 13 commits January 7, 2025 11:23

[red-knot] add call signature checking

3723ebc

minor code review changes

e4f78f1

use * and ** prefixes on names of variadic parameters

17a16b2

Use parameter indices for positional-only parameters

6a11f7c

Include function name in invalid-argument-type errors

85ed264

Include function name in too-many-positional-arguments errors

3a655af

Include function name in parameter-already-assigned errors

3704fa3

Consolidate missing-arguments errors

1b51138

fix benchmark

3213a84

Vec instead of VecDeque for CallArguments

4777f56

Expose Parameters instead of various parameter methods on Signature

d00a388

Avoid requiring an ast::name::Name just for lookup

7f668a1

Use Option<Type> in Signature instead of Unknown for missing annotation

072015e

carljm added 7 commits January 7, 2025 11:24

Simplify CallBindingError::UnknownArgument member names

95a15d7

Remove comment about using SmallVec

3deedca

Give index in diagnostic if argument is passed positionally

c57498c

review nits

c7bf734

one-based parameter indexing in diagnostics

811b697

more function names in diagnostics

ef968f3

add comment

24b7d7c

carljm force-pushed the cjm/checksigs branch from b2e3bf1 to 24b7d7c Compare January 7, 2025 19:24

carljm added 3 commits January 7, 2025 11:30

fix benchmark

ee0f9e3

restructure Parameter

e338e99

add some tests for invalid-syntax cases

329e562

fix expect message

2b4ad16

carljm enabled auto-merge (squash) January 7, 2025 20:35

carljm merged commit f2a86fc into main Jan 7, 2025
20 checks passed

carljm deleted the cjm/checksigs branch January 7, 2025 20:39

Comments

Conversation

carljm commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

github-actions bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carljm commented Jan 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carljm commented Jan 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

carljm commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

`ruff-ecosystem` results